-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AndroidCrypto] Handle setting non-default SslProtocols #50987
Conversation
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue Details
|
d8f4830
to
b106226
Compare
src/libraries/Native/Unix/System.Security.Cryptography.Native.Android/pal_ssl.c
Outdated
Show resolved
Hide resolved
src/libraries/Native/Unix/System.Security.Cryptography.Native.Android/pal_sslstream.c
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interop work looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I personally feel it would be ok to not worry about SSL2&3.
We drag them as legacy compat but they should be long dead.
Since Android probably does not have that baggage we may have more freedom.
Many Linux distributions do not supported them in practice as well.
I like that thought of not dragging along SSL3 as legacy compat - especially since the Android platform dropped support for it a couple of versions/years ago. |
SslProtocols
Ssl2
andSsl3
are not supported,Tls13
is only supported on some (newer) versionswrap
/unwrap
givesBUFFER_OVERFLOW
EncryptionPolicy.NoEncryption
is requested (not supported on Android)Ssl3
andTls13
on Androidcc @jkoritzinsky @steveisok @AaronRobinsonMSFT @bartonjs @wfurt