Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change GC committed bytes unit to MB #51031

Merged
merged 2 commits into from
Apr 10, 2021
Merged

change GC committed bytes unit to MB #51031

merged 2 commits into from
Apr 10, 2021

Conversation

sywhang
Copy link
Contributor

@sywhang sywhang commented Apr 9, 2021

Changing the unit of this counter to MB as discussed here.

cc @davidfowl

@sywhang sywhang requested a review from josalem April 9, 2021 23:14
davidfowl
davidfowl approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change the other ones to use 1_000_000 as well

@davidfowl
Copy link
Member

cc @stephentoub for the test failure

@sywhang sywhang merged commit b05a892 into dotnet:main Apr 10, 2021
@sywhang sywhang deleted the dev/suwhang/change-committed-bytes-counter-mb branch April 10, 2021 07:45
@sywhang sywhang mentioned this pull request Apr 12, 2021
Merged
@ghost ghost locked as resolved and limited conversation to collaborators May 10, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@josalem josalem Awaiting requested review from josalem

Assignees
No one assigned
Labels
area-Tracing-coreclr
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@sywhang @davidfowl @karelz