Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal String.{Try}CopyTo and use in a few places in corelib #51062

Merged
merged 2 commits into from
Apr 11, 2021

Conversation

stephentoub
Copy link
Member

We can use in more if it's made public.

Contributes to #51061
Contributes to #50601

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@GrabYourPitchforks GrabYourPitchforks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment on micro-optimizations to codegen. Otherwise LGTM. I double-checked that all modified call sites already expect the source string to be non-null.

Co-authored-by: Levi Broderick <GrabYourPitchforks@users.noreply.github.com>
@ghost
Copy link

ghost commented Apr 11, 2021

Hello @stephentoub!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@stephentoub stephentoub merged commit 9bb0427 into dotnet:main Apr 11, 2021
@stephentoub stephentoub deleted the stringcopyto branch April 11, 2021 17:52
@ghost ghost locked as resolved and limited conversation to collaborators May 11, 2021
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants