-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-revert "Fold overflow operations in value numbering" #51440
Merged
sandreenko
merged 24 commits into
dotnet:main
from
SingleAccretion:Fold-Overflow-Operations-In-Value-Numbering-No-Helpers
May 26, 2021
Merged
Re-revert "Fold overflow operations in value numbering" #51440
sandreenko
merged 24 commits into
dotnet:main
from
SingleAccretion:Fold-Overflow-Operations-In-Value-Numbering-No-Helpers
May 26, 2021
Commits on May 22, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9c01c96 - Browse repository at this point
Copy the full SHA 9c01c96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4cafa8c - Browse repository at this point
Copy the full SHA 4cafa8cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96b4d20 - Browse repository at this point
Copy the full SHA 96b4d20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 82c460d - Browse repository at this point
Copy the full SHA 82c460dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a711aa - Browse repository at this point
Copy the full SHA 4a711aaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0d18ab0 - Browse repository at this point
Copy the full SHA 0d18ab0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0a049d6 - Browse repository at this point
Copy the full SHA 0a049d6View commit details -
Moved checking of overflow for arithmetic operations from gtFoldExprC…
…onst into a separate namespace
Configuration menu - View commit details
-
Copy full SHA for 10f2dcb - Browse repository at this point
Copy the full SHA 10f2dcbView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa1ab87 - Browse repository at this point
Copy the full SHA fa1ab87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ab7753 - Browse repository at this point
Copy the full SHA 9ab7753View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c66ac1 - Browse repository at this point
Copy the full SHA 0c66ac1View commit details -
Made the definition of var_types a standalone header so that it can b…
…e safely #included'ed in utils.h
Configuration menu - View commit details
-
Copy full SHA for c2d4d79 - Browse repository at this point
Copy the full SHA c2d4d79View commit details -
Refactored gtFoldExpr some more, moved the overflow checking logic to…
… CheckedOps, implemented overflow checking for floating point -> integer casts
Configuration menu - View commit details
-
Copy full SHA for 9c67714 - Browse repository at this point
Copy the full SHA 9c67714View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99a9829 - Browse repository at this point
Copy the full SHA 99a9829View commit details
Commits on May 24, 2021
-
They throw and catch quite a few exceptions.
Configuration menu - View commit details
-
Copy full SHA for 81f9ed3 - Browse repository at this point
Copy the full SHA 81f9ed3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4467b08 - Browse repository at this point
Copy the full SHA 4467b08View commit details -
Made arithmetic CheckedOps functions templated
Reduces code duplication and obviates the need for some conditions and casts. They use the implementation from the Long* variants of the old functions, except for "SubOverflows", where some instantiations, unreachable at runtime, were using "size_t" as the type argument and causing warnings. The relevant part of "AddOverflows" has been inlined into "SubOverflows".
Configuration menu - View commit details
-
Copy full SHA for 59dc67f - Browse repository at this point
Copy the full SHA 59dc67fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0580145 - Browse repository at this point
Copy the full SHA 0580145View commit details -
Configuration menu - View commit details
-
Copy full SHA for b64e00a - Browse repository at this point
Copy the full SHA b64e00aView commit details -
Co-authored-by: Anton Lapounov <anton.lapounov@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 610b612 - Browse repository at this point
Copy the full SHA 610b612View commit details
Commits on May 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 2982f40 - Browse repository at this point
Copy the full SHA 2982f40View commit details -
Apply suggestions from code review
Co-authored-by: Anton Lapounov <anton.lapounov@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for f26f1b8 - Browse repository at this point
Copy the full SHA f26f1b8View commit details -
Assert type != TYP_BYREF in VNEvalShouldFold
The method is not prepared to handle them. Also add a note about that to the header. Also delete TODO-Review about it. Right now the only caller of VNEvalShouldFold guards against TYP_BYREF folding, so this assert is a safety measure against future callers not taking byrefs into account.
Configuration menu - View commit details
-
Copy full SHA for 09fc5b9 - Browse repository at this point
Copy the full SHA 09fc5b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ef91357 - Browse repository at this point
Copy the full SHA ef91357View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.