Enable iOS/tvOS simulators on arm64

[steveisok]

No description provided.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[steveisok]

@akoeplinger Interesting error on arm64 simulator:

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-51536-merge-29f7a57527f24b9d93/HelloiOS/console.f22e094b.log?sv=2019-07-07&se=2021-05-10T01%3A13%3A26Z&sr=c&sp=rl&sig=y793uEF2pkU6jpQgqCMvUmvrDpUIYbpG97c2z%2Fd7Q8A%3D

error MT0117: Can't launch a 32-bit app on a simulator that only supports 64-bit apps (iPhone X (iOS 14.4) - created by XHarness).
[18:13:57] dbug: 18:13:57.8468270
[18:13:57] dbug: 18:13:57.8641960   at Xamarin.Launcher.SimController.Ensure64bitApp (Xamarin.Hosting.Bindings.SimDevice device, Xamarin.Hosting.AppBundle app_bundle) [0x00060] in <fd345040cf8646afbcdd85e8867162a4>:0
[18:13:57] dbug: 18:13:57.8642500   at Xamarin.Launcher.SimController.SelectAppArchitecture (Xamarin.Hosting.Bindings.SimDevice device, Xamarin.Hosting.AppBundle app_bundle) [0x000bb] in <fd345040cf8646afbcdd85e8867162a4>:0
[18:13:57] dbug: 18:13:57.8642640   at Xamarin.Launcher.SimController.InstallAsync (Xamarin.Hosting.SimulatorInstallConfig config) [0x0001c] in <fd345040cf8646afbcdd85e8867162a4>:0

[filipnavara]

@steveisok That's not too surprising given the code in Ensure64bitApp:

	IEnumerable<MachOFile> files = MachO.Read(app_bundle.ExecutablePath);
	foreach (MachOFile file in files)
	{
		if (file.Architecture == MachO.Architectures.x86_64)
		{
			return;
		}
	}

Unfortunately it's the closed source part of Xamarin so I cannot submit a PR. The check should likely be extended to allow ARM64 and ARM64e.

[akoeplinger]

@mandel-macaque @premun would you mind fixing the mlaunch code to support arm64 simulators?

[premun]

@akoeplinger I opened a PR with a following fix:

Do you have an ARM64 machine at hand? I can send you the built mlaunch with this fix and you can test the run (using --mlaunch arg on XHarness)?

[akoeplinger]

Yep I do have an arm64 mac, but I'm about to hop into a meeting. Can you attach the new mlaunch here?

[premun]

mlaunch.tar.gz
then

xharness apple test ... --mlaunch=mlaunch.app/Contents/MacOS/mlaunch

[akoeplinger]

@premun I tested and it works :)

[lambdageek]

This is just temporarily commented out, right?

[steveisok]

Yes, once the sanity check passes, I'll enable the rest.

[ghost]

Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it.

[lambdageek]

We should give this another go using "JustInterp" (--aot=interp) mode like in #53197. The cross-compilers should be in better shape because most of the no-exec stuff was not catalyst-specific.

[steveisok]

@lambdageek After a few adjustments on my local build, it's now failing on

appdomain.c:197, condition `is_ok (error)' not met, function:create_domain_objects, Attempting to JIT compile method 'void System.OutOfMemoryException:.ctor (string)' while running in aot-only mode.

[lambdageek]

@steveisok the src/tasks/AppleAppBuilder/Templates/runtime.m template needs to be adjusted to set the AOT mode to MONO_AOT_MODE_INTERP.

We have all that stuff conditioned on TARGET_OS_MACCATALYST, but probably we should have some more direct way to pass down the appropriate AOT mode (instead of trying to guess from the target and from the force aot / force interpreter values) from the Xcode.cs down to the CMakeLists.txt template and down to runtime.m

runtime/src/tasks/AppleAppBuilder/Templates/runtime.m

Lines 300 to 310 in 0416c34

	#elif (!TARGET_OS_SIMULATOR && !TARGET_OS_MACCATALYST) || FORCE_AOT
	register_dllmap ();
	// register modules
	register_aot_modules ();
	#if (FORCE_INTERPRETER && TARGET_OS_MACCATALYST)
	os_log_info (OS_LOG_DEFAULT, "AOT INTERP Enabled");
	mono_jit_set_aot_mode (MONO_AOT_MODE_INTERP);
	#else
	mono_jit_set_aot_mode (MONO_AOT_MODE_FULL);
	#endif

[ghost]

Draft Pull Request was automatically closed for inactivity. Please let us know if you'd like to reopen it.