Task/use get last p invoke error #52003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
KZedan
force-pushed
the
Task/Use_GetLastPInvokeError
branch
from
0e515ed
to
b7abc3c
Compare
|
@danmoseley @stephentoub @jkotas Hooray, no? |
|
I would expect that there are more GetLastPInvokeError that can be replaced, but this is a fine incremental step. |
jkotas
approved these changes
Apr 29, 2021
Hooray, yes! Next step would be for someone to change most of the Win32Exceptions we throw in Networking to the derived types that already exist there: Perhaps @KZedan is interested in that too. |
|
The failures are known issue #52031 |
|
@danmoseley @jkotas has mentioned there are more that can be changed so I will take another look at that first 😃 |
|
@KZedan Really appreciate your help here. Please don't hesitate to tag me or @elinor-fung if you hit any issues. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing GetLastWin32Error() with GetLastPInvokeError() as method name is more descriptive of usage.
Fixes #51648