Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ComDisabled tests on Mono #52128

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Disable ComDisabled tests on Mono #52128

merged 1 commit into from
Apr 30, 2021

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Apr 30, 2021 •
edited
Loading

Mono doesn't have built-in COM support, so we shouldn't be running these.

@elinor-fung elinor-fung mentioned this pull request Apr 30, 2021
Merged
@runfoapp runfoapp bot mentioned this pull request Apr 30, 2021
Closed
@elinor-fung
Copy link
Member Author

elinor-fung commented Apr 30, 2021 •
edited
Loading

Failure (already linked) is unrelated.

runtime-staging build for mono on Windows is no longer running the test:
https://dev.azure.com/dnceng/public/_build/results?buildId=1116480&view=logs&jobId=c8204876-824e-5bf9-8c45-a4628bfcec7d&j=585f1246-0618-5d47-ff3e-08c83309e2d2&t=5e10daf8-cc46-5bd4-2ab7-d28eafd857b5

@elinor-fung elinor-fung merged commit 94221f3 into dotnet:main Apr 30, 2021
@elinor-fung elinor-fung deleted the disableComDisabledTest branch April 30, 2021 21:47
@davidfowl davidfowl mentioned this pull request May 1, 2021
Merged
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LakshanF LakshanF LakshanF approved these changes

Assignees
No one assigned
Labels
area-Interop-coreclr
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elinor-fung @LakshanF @karelz