Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wasm][debugger] Reuse debugger-agent on wasm debugger #52300

Merged
merged 49 commits into from
Jun 23, 2021
Merged

[wasm][debugger] Reuse debugger-agent on wasm debugger #52300

merged 49 commits into from
Jun 23, 2021

Commits on May 5, 2021

  1. Trying to reuse debugger-agent on wasm debugger. This will remove a l… 

    …ot of code that does the same thing on mini-wasm-debugger.
    @thaystg
    thaystg committed May 5, 2021
    Configuration menu
    Copy the full SHA
    7d8de9c View commit details
    Browse the repository at this point in the history

  2. Replace remove_breakpoint and clear_all_breakpoints with the ones on … 

    …debugger-agent and remove unused code.
    @thaystg
    thaystg committed May 5, 2021
    Configuration menu
    Copy the full SHA
    8be82ed View commit details
    Browse the repository at this point in the history

Commits on May 6, 2021

  1. Stepping and callstack using debugger-agent.

    @thaystg
    thaystg committed May 6, 2021
    Configuration menu
    Copy the full SHA
    1fa738d View commit details
    Browse the repository at this point in the history

  2. Remove more code.

    @thaystg
    thaystg committed May 6, 2021
    Configuration menu
    Copy the full SHA
    f97cf27 View commit details
    Browse the repository at this point in the history

  3. Get frame values using debugger-agent.

    @thaystg
    thaystg committed May 6, 2021
    Configuration menu
    Copy the full SHA
    0242f6a View commit details
    Browse the repository at this point in the history

Commits on May 11, 2021

  1. Working valuetypes and call function on valuetypes. 

    make -C src/mono/wasm/ run-debugger-tests TEST_FILTER=DebuggerTests.SteppingTests.InspectValueTypeMethodArgsWhileStepping is working without use_cfo.
    @thaystg
    thaystg committed May 11, 2021
    Configuration menu
    Copy the full SHA
    adae934 View commit details
    Browse the repository at this point in the history

Commits on May 12, 2021

  1. Failed: 316, Passed: 175

    @thaystg
    thaystg committed May 12, 2021
    Configuration menu
    Copy the full SHA
    1f620dc View commit details
    Browse the repository at this point in the history

  2. Failed: 307, Passed: 184, Skipped: 0, Total: 491

    @thaystg
    thaystg committed May 12, 2021
    Configuration menu
    Copy the full SHA
    4bf5e0c View commit details
    Browse the repository at this point in the history

  3. Failed: 280, Passed: 211

    @thaystg
    thaystg committed May 12, 2021
    Configuration menu
    Copy the full SHA
    c853b1b View commit details
    Browse the repository at this point in the history

  4. Failed: 277, Passed: 214

    @thaystg
    thaystg committed May 12, 2021
    Configuration menu
    Copy the full SHA
    372157a View commit details
    Browse the repository at this point in the history

Commits on May 13, 2021

  1. Implemented boxed value. 

    Failed:   271, Passed:   220
    @thaystg
    thaystg committed May 13, 2021
    Configuration menu
    Copy the full SHA
    d837444 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Implementing get properties on objects. 

    Implementing handling error on debugger-agent.
    @thaystg
    thaystg committed May 14, 2021
    Configuration menu
    Copy the full SHA
    07ff48a View commit details
    Browse the repository at this point in the history

Commits on May 17, 2021

  1. Implementing callfunctionon object. 

    Failed:   248, Passed:   243
    @thaystg
    thaystg committed May 17, 2021
    Configuration menu
    Copy the full SHA
    6585dce View commit details
    Browse the repository at this point in the history

  2. Implementing get pointer values. 

    Failed:   243, Passed:   248
    @thaystg
    thaystg committed May 17, 2021
    Configuration menu
    Copy the full SHA
    adbe8de View commit details
    Browse the repository at this point in the history

  3. Fixing pointer values and implement call on function with pointers. 

    Failed:   226, Passed:   265
    @thaystg
    thaystg committed May 17, 2021
    Configuration menu
    Copy the full SHA
    7be985c View commit details
    Browse the repository at this point in the history

Commits on May 19, 2021

  1. Reimplement call function on, and implement set values. 

    Failed:   192, Passed:   299
    @thaystg
    thaystg committed May 19, 2021
    Configuration menu
    Copy the full SHA
    8f88612 View commit details
    Browse the repository at this point in the history

  2. Failed: 192, Passed: 299

    @thaystg
    thaystg committed May 19, 2021
    Configuration menu
    Copy the full SHA
    478016d View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Fixing valuetype with null values. 

    Failed:   184, Passed:   307
    @thaystg
    thaystg committed May 20, 2021
    Configuration menu
    Copy the full SHA
    50d657e View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Implemented Evaluate expressions, conditional breakpoints, all breakp… 

    …oints tests are passing.

Failed:   172, Passed:   319
    @thaystg
    thaystg committed May 21, 2021
    Configuration menu
    Copy the full SHA
    212c081 View commit details
    Browse the repository at this point in the history

  2. Fixing evaluate with value type. 

    Failed:   156, Passed:   335
    @thaystg
    thaystg committed May 21, 2021
    Configuration menu
    Copy the full SHA
    7186b98 View commit details
    Browse the repository at this point in the history

  3. Trim part and add cache. 

    Failed:   148, Passed:   343
    @thaystg
    thaystg committed May 21, 2021
    Configuration menu
    Copy the full SHA
    26cf882 View commit details
    Browse the repository at this point in the history

  4. Fixing evaluate expression. 

    Failed:    99, Passed:   392
    @thaystg
    thaystg committed May 21, 2021
    Configuration menu
    Copy the full SHA
    a8f98b5 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. GetPropertiesTests working. 

    Failed:    53, Passed:   438
    @thaystg
    thaystg committed May 25, 2021
    Configuration menu
    Copy the full SHA
    4010546 View commit details
    Browse the repository at this point in the history

  2. Passing delegate tests. 

    Failed:    31, Passed:   460
    @thaystg
    thaystg committed May 25, 2021
    Configuration menu
    Copy the full SHA
    fb323d0 View commit details
    Browse the repository at this point in the history

  3. Removing unused code.

    @thaystg
    thaystg committed May 25, 2021
    Configuration menu
    Copy the full SHA
    380e6dd View commit details
    Browse the repository at this point in the history

Commits on May 26, 2021

  1. Implementing exception handler. 

    Failed:    30, Passed:   461
    @thaystg
    thaystg committed May 26, 2021
    Configuration menu
    Copy the full SHA
    0712ae1 View commit details
    Browse the repository at this point in the history

  2. Fixing cfo returning array. 

    Removing more code.
Removing 2 tests that tests functions which does not exist anymore.
Failed:    18, Passed:   471
    @thaystg
    thaystg committed May 26, 2021
    Configuration menu
    Copy the full SHA
    d143ecf View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. Fix CallFunctionOn returning primitive types and null. 

    Failed:     9, Passed:   480
    @thaystg
    thaystg committed May 27, 2021
    Configuration menu
    Copy the full SHA
    0a4c964 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Failed: 7, Passed: 482

    @thaystg
    thaystg committed May 28, 2021
    Configuration menu
    Copy the full SHA
    d90031b View commit details
    Browse the repository at this point in the history

  2. Fixing some tests. 

    Failed:     2, Passed:   488
    @thaystg
    thaystg committed May 28, 2021
    Configuration menu
    Copy the full SHA
    c41ad02 View commit details
    Browse the repository at this point in the history

  3. Removing a lot of code. 

    Failed:     4, Passed:   485
    @thaystg
    thaystg committed May 28, 2021
    Configuration menu
    Copy the full SHA
    2581d1d View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. 0 ERRORS!

    @thaystg
    thaystg committed May 31, 2021
    Configuration menu
    Copy the full SHA
    150aeac View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2021

  1. Removing more code. 

    No errors.
    @thaystg
    thaystg committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    9155bba View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/main' into thays_remove_mini_w… 

    …asm_debugger_and_use_debugger_agent

* upstream/main: (597 commits)
  Fix42292 (dotnet#52463)
  [mono] Remove some obsolete emscripten flags. (dotnet#53486)
  Fixed path to projects (dotnet#53435)
  support ServerCertificateContext in quic (dotnet#53175)
  Socket: delete unix local endpoint filename on Close (dotnet#52103)
  [mono] Fix sgen_gc_info.memory_load_bytes (dotnet#53364)
  Refactor MsQuic's native IP address types. (dotnet#53461)
  Re-enabled optimizations for gtFoldExprConst (dotnet#53347)
  Add diagnostic support into sample app and AppBuilders on Mono. (dotnet#53361)
  Fix issues with virtuals and mdarrays (dotnet#53400)
  Split Variant marshalling tests (dotnet#53035)
  Update clrjit.natvis to cover GT_SIMD and GT_HWINTRINSIC (dotnet#53470)
  remove WSL checks in tests (dotnet#53475)
  Always spawn message loop thread for SystemEvents (dotnet#53467)
  add AcceptAsync cancellation overloads (dotnet#53340)
  Remove unnecessary reference to iOS workload pack in the Mono workload (dotnet#53425)
  Add CookieContainer.GetAllCookies (dotnet#53441)
  Remove DynamicallyAccessedMembers on JsonSerializer  (dotnet#53235)
  [wasm] Re-enable Wasm.Build.Tests (dotnet#53433)
  [libraries] Move library tests Feature Switches defaults to Functional tests (dotnet#53253)
  ...
    @thaystg
    thaystg committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    c4bf8fc View commit details
    Browse the repository at this point in the history

  3. Fixing added tests.

    @thaystg
    thaystg committed Jun 1, 2021
    Configuration menu
    Copy the full SHA
    650b405 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Return javascript callstack after managed callstack. 

    Step out from managed code return to native wasm or javascript.
Adding debug info to Wasm.Browser.Sample to help testing debugger with sample.
    @thaystg
    thaystg committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    62de11b View commit details
    Browse the repository at this point in the history

  2. Change what Ankit suggested. 

    Clear cache with valuetypes and pointers after resume or step.
    @thaystg
    thaystg committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    da783b6 View commit details
    Browse the repository at this point in the history

  3. Fixing suggestions.

    @thaystg
    thaystg committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    8d0005f View commit details
    Browse the repository at this point in the history

  4. Fix error on wasm build.

    @thaystg
    thaystg committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    67723dc View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Larry Ewing <lewing@microsoft.com>
    @thaystg @lewing
    thaystg and lewing authored Jun 11, 2021
    Configuration menu
    Copy the full SHA
    00a459e View commit details
    Browse the repository at this point in the history

  2. Changing what was suggested by @lewing.

    @thaystg
    thaystg committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    d3abbf2 View commit details
    Browse the repository at this point in the history

  3. Fix pointer tests.

    @thaystg
    thaystg committed Jun 11, 2021
    Configuration menu
    Copy the full SHA
    c4c9fa3 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Refactoring CreateJObjectForVariableValue

    @thaystg
    thaystg committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    fc8ec74 View commit details
    Browse the repository at this point in the history

  2. Changing what @lewing suggested.

    @thaystg
    thaystg committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    62b15f8 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Larry Ewing <lewing@microsoft.com>
    @thaystg @lewing
    thaystg and lewing authored Jun 17, 2021
    Configuration menu
    Copy the full SHA
    f797f9e View commit details
    Browse the repository at this point in the history

  2. Update src/mono/wasm/debugger/BrowserDebugProxy/MonoProxy.cs 

    Co-authored-by: Larry Ewing <lewing@microsoft.com>
    @thaystg @lewing
    thaystg and lewing authored Jun 17, 2021
    Configuration menu
    Copy the full SHA
    5b2994d View commit details
    Browse the repository at this point in the history

  3. Update src/mono/wasm/debugger/BrowserDebugProxy/MonoSDBHelper.cs 

    Co-authored-by: Larry Ewing <lewing@microsoft.com>
    @thaystg @lewing
    thaystg and lewing authored Jun 17, 2021
    Configuration menu
    Copy the full SHA
    d4f1d87 View commit details
    Browse the repository at this point in the history

  4. Fixing @lewing changes.

    @thaystg
    thaystg committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    6645cc5 View commit details
    Browse the repository at this point in the history

  5. Trying to fix CI.

    @thaystg
    thaystg committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    a61f75e View commit details
    Browse the repository at this point in the history