-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use MicrosoftDotNet500 cert for executable files #52336
Conversation
Use this for .msi files, and update the incoming arcade provided defaults with MicrosoftDotNet500. Do not use the UseDotNetCertificate property as this repo does not use Publish.proj
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
Official build testing this https://dev.azure.com/dnceng/internal/_build/results?buildId=1124304&view=results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm looking at the internal build, but the change LGTM
Merged manifest looks correct. |
cc @riarenas. When we switch to Publish.proj we want to set UseDotNetCertificate so that the right cert is chosen. |
Rerunning the test. However, the failure was an AzDO test plan 503:
|
The manifest and diagnostics assets look correct. |
If you're completely using publish.proj, I think this will work. If any custom |
Use this for .msi files, and update the incoming arcade provided defaults with MicrosoftDotNet500.
Do not use the UseDotNetCertificate property as this repo does not use Publish.proj