Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use MicrosoftDotNet500 cert for executable files #52336

Merged
merged 1 commit into from
May 6, 2021

Conversation

mmitche
Copy link
Member

@mmitche mmitche commented May 5, 2021

Use this for .msi files, and update the incoming arcade provided defaults with MicrosoftDotNet500.
Do not use the UseDotNetCertificate property as this repo does not use Publish.proj

Use this for .msi files, and update the incoming arcade provided defaults with MicrosoftDotNet500.
Do not use the UseDotNetCertificate property as this repo does not use Publish.proj
@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@mmitche
Copy link
Member Author

mmitche commented May 5, 2021

Copy link
Member

@hoyosjs hoyosjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking at the internal build, but the change LGTM :shipit:

@mmitche
Copy link
Member Author

mmitche commented May 6, 2021

Merged manifest looks correct.

@ViktorHofer
Copy link
Member

cc @riarenas. When we switch to Publish.proj we want to set UseDotNetCertificate so that the right cert is chosen.

@hoyosjs
Copy link
Member

hoyosjs commented May 6, 2021

Rerunning the test. However, the failure was an AzDO test plan 503:

Searching '/root/helix/work/workitem/uploads' for test results files
Worker 0: got error: Traceback (most recent call last):
  File "/root/helix/work/correlation/reporter/run.py", line 44, in run
    self.__process(item)
  File "/root/helix/work/correlation/reporter/run.py", line 34, in __process
    self.publisher.upload_batch(batch)
  File "/root/helix/work/correlation/reporter/azure_devops_result_publisher.py", line 35, in upload_batch
    self.publish_results(test_case_results, test_name_order, results_with_attachments)
  File "/root/helix/work/correlation/reporter/azure_devops_result_publisher.py", line 70, in publish_results
    published_results = test_client.add_test_results_to_test_run(list(test_case_results), self.team_project, self.test_run_id)  # type: List[TestCaseResult]
  File "/home/helixbot/.azdo-env/lib/python3.7/site-packages/azure/devops/v5_1/test/test_client.py", line 679, in add_test_results_to_test_run
    content=content)
  File "/home/helixbot/.azdo-env/lib/python3.7/site-packages/azure/devops/client.py", line 104, in _send
    response = self._send_request(request=request, headers=headers, content=content, media_type=media_type)
  File "/home/helixbot/.azdo-env/lib/python3.7/site-packages/azure/devops/client.py", line 68, in _send_request
    self._handle_error(request, response)
  File "/home/helixbot/.azdo-env/lib/python3.7/site-packages/azure/devops/client.py", line 272, in _handle_error
    status_code=response.status_code))
azure.devops.exceptions.AzureDevOpsClientRequestError: Operation returned an invalid status code of 503.

@hoyosjs
Copy link
Member

hoyosjs commented May 6, 2021

The manifest and diagnostics assets look correct.

@mmitche
Copy link
Member Author

mmitche commented May 6, 2021

cc @riarenas. When we switch to Publish.proj we want to set UseDotNetCertificate so that the right cert is chosen.

If you're completely using publish.proj, I think this will work. If any custom PushToAzureDevOpsArtifacts calls still exist, then you'll need to use this method.

@mmitche mmitche merged commit be4303a into dotnet:main May 6, 2021
@mmitche mmitche deleted the use-new-cert branch May 6, 2021 14:41
@karelz karelz added this to the 6.0.0 milestone May 20, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants