Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow build with VS2022 installed #52487

Merged
merged 1 commit into from
May 10, 2021
Merged

Conversation

BrennanConroy
Copy link
Member

No description provided.

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@danmoseley danmoseley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, if it works for you.

@danmoseley
Copy link
Member

@dotnet/dnceng

Found results file /root/helix/work/workitem/testResults.xml with format xunit
Searching '/root/helix/work/workitem/uploads' for test results files
Worker 0: got error: Traceback (most recent call last):
  File "/root/helix/work/correlation/reporter/run.py", line 44, in run
    self.__process(item)
  File "/root/helix/work/correlation/reporter/run.py", line 34, in __process
    self.publisher.upload_batch(batch)
  File "/root/helix/work/correlation/reporter/azure_devops_result_publisher.py", line 35, in upload_batch
    self.publish_results(test_case_results, test_name_order, results_with_attachments)
  File "/root/helix/work/correlation/reporter/azure_devops_result_publisher.py", line 70, in publish_results
    published_results = test_client.add_test_results_to_test_run(list(test_case_results), self.team_project, self.test_run_id)  # type: List[TestCaseResult]
  File "/home/helixbot/.azdo-env/lib/python3.8/site-packages/azure/devops/v5_1/test/test_client.py", line 675, in add_test_results_to_test_run
    response = self._send(http_method='POST',
  File "/home/helixbot/.azdo-env/lib/python3.8/site-packages/azure/devops/client.py", line 104, in _send
    response = self._send_request(request=request, headers=headers, content=content, media_type=media_type)
2021-05-08 02:21:31,904: INFO: 140019813375304: run(114): main: Main thread exiting
  File "/home/helixbot/.azdo-env/lib/python3.8/site-packages/azure/devops/client.py", line 68, in _send_request
    self._handle_error(request, response)
  File "/home/helixbot/.azdo-env/lib/python3.8/site-packages/azure/devops/client.py", line 271, in _handle_error
    raise AzureDevOpsClientRequestError(full_message_format.format(error_message=error_message,
azure.devops.exceptions.AzureDevOpsClientRequestError: Operation returned an invalid status code of 503.

https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-52487-merge-591b81bc58264264ae/Microsoft.Extensions.Hosting.Unit.Tests/console.eb866017.log?sv=2019-07-07&se=2021-05-28T01%3A55%3A10Z&sr=c&sp=rl&sig=0iKoGlNoY%2FhKlVjDU6ls%2FvKAGPmUMKuX3aUpndBIneY%3D

@danmoseley
Copy link
Member

The other issue is #52527.

@danmoseley danmoseley merged commit e688fcf into dotnet:main May 10, 2021
@danmoseley
Copy link
Member

thanks @BrennanConroy

@lpatalas
Copy link

@danmoseley Regarding the failure you linked above #52487 (comment) - it's probably intermittent AzDO issue. @MattGal elaborated a bit more about it here: #52420 (comment).

@ViktorHofer
Copy link
Member

cc @AntonLapounov

should we also update

if /i "%__VSVersion%" == "vs2019" (set __CmakeGenerator=%__CmakeGenerator% 16 2019)
if /i "%__VSVersion%" == "vs2017" (set __CmakeGenerator=%__CmakeGenerator% 15 2017)
or change it so that it doesn't hardcode the VS versions?

@AntonLapounov
Copy link
Member

At present CMake has no special support for Visual Studio 2022, so we should probably use "Visual Studio 16 2019" unconditionally for now. The vs2017 line may be deleted.

@karelz karelz added this to the 6.0.0 milestone May 20, 2021
hoyosjs added a commit that referenced this pull request Jun 1, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants