Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One Shot ECB #52510
One Shot ECB #52510
Changes from 21 commits
4e831fd
0192aeb
3648777
ba0391e
21e3760
7505b6a
ef12105
7a808fd
835cf76
7a72745
425f6c8
5fd05ca
b205986
0768841
bf32394
5993181
7d0ea8d
9dbd999
a853ccd
1df32b7
720018b
b32fd8a
b1c6ea3
02d68cb
ccdecda
500b829
2d43ec7
3f0c165
16ff27f
b315f93
03b5564
1ebb11c
23fe2a6
1c65eec
f20f7aa
0d76e80
33c649d
0e3b568
d017f9d
18f2478
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to take the block size parameter separately and get rid of the algorithm/this parameter? Then nothing could sneak its way in.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably; I wanted to clean this all up a bit when I get to the CFB implementation. There's a bit of weirdness of so many things being passed around... some of it is in bits, some of it is in bytes...