Make Logging Generator handle null input better #52727
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @maryamariyan Issue DetailsFixes: #52277
|
eerhardt
reviewed
May 14, 2021
| @@ -115,7 +120,7 @@ public IReadOnlyList<LoggerClass> GetLogClasses(IEnumerable<ClassDeclarationSynt | |||
| Name = methodSymbol.Name, | |||
| Level = level, | |||
| Message = message, | |||
| EventId = eventId, | |||
| EventId = (int)eventId.Value, | |||
There was a problem hiding this comment.
Why do we need a cast to (int) here?
There was a problem hiding this comment.
A more performant way would be to use GetValueOrDefault() instead of Value. It skips the second not null check, which was already done in .HasValue above
eerhardt
reviewed
May 14, 2021
| { | ||
| int eventId = 0; | ||
| int? eventId = 0; |
There was a problem hiding this comment.
Should this be int? eventId = null;?
24 tasks
|
Closing this PR, addressing this fix in another one. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #52277