Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow TimeZoneInfo display names to use any of the installed Windows languages #53119

Merged
merged 2 commits into from
May 22, 2021

Conversation

mattjohnsonpint
Copy link
Contributor

Resubmitting #52992 that was reverted with #53112, but with changes needed to prevent the issue that was logged in #53110.

Fixes #50310

@tarekgh, @jkotas - the changes are in the second commit. Please let me know if this is the preferred approach or if I should handle it differently. Thanks.

@ghost
Copy link

ghost commented May 22, 2021

Tagging subscribers to this area: @tannergooding
See info in area-owners.md if you want to be subscribed.

Issue Details

Resubmitting #52992 that was reverted with #53112, but with changes needed to prevent the issue that was logged in #53110.

Fixes #50310

@tarekgh, @jkotas - the changes are in the second commit. Please let me know if this is the preferred approach or if I should handle it differently. Thanks.

Author: mattjohnsonpint
Assignees: -
Labels:

area-System.Runtime

Milestone: -

@jkotas
Copy link
Member

jkotas commented May 22, 2021

Yes, this approach works. Thank you!

@mattjohnsonpint
Copy link
Contributor Author

Hmm. Still two failures. I need some help debugging this. Thanks.

@jkotas
Copy link
Member

jkotas commented May 22, 2021

It does not look related to your change. I have triggered rerun to make sure.

@tarekgh tarekgh merged commit f53ae47 into dotnet:main May 22, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Jun 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Time zone display names are locked to the default display language on Windows
4 participants