-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm][xharness] install development SSL certificate on Helix agent before xharness run via SDK or powershell #53339
Conversation
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer |
/azp run runtime-libraries-mono outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/sendtohelixhelp.proj
Outdated
--> | ||
<PropertyGroup Condition="''$(TestPackages)' != 'true' and $(TargetsWindows)' != 'true' and '$(BrowserHost)' != 'windows'"> | ||
<!-- install SDK so that, we could use `dotnet dev-certs https`. --> | ||
<IncludeDotNetCli>true</IncludeDotNetCli> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will IncludeDotNetCli
be set for Windows as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can set this one in the bottom with HelixPreCommands
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if powershell works for windows, we do not need full SDK.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know but we still need IncludeDotNetCli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's there by xharness already , but ok I will make it explicit https://github.com/dotnet/arcade/blob/6b9758661f4483a70654bcaf6f8d7c6a79ee5660/src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/XHarnessRunner.targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then we don't need it at all?
/azp run runtime-libraries-mono outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Caused by #53180, #53225
The original approach to install certificates didn't work because we don't have dotnet SDK, just runtime on some helix agents.
Fixes #53207