Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm][xharness] install development SSL certificate on Helix agent before xharness run via SDK or powershell #53339

Closed

Conversation

pavelsavara
Copy link
Member

Caused by #53180, #53225
The original approach to install certificates didn't work because we don't have dotnet SDK, just runtime on some helix agents.
Fixes #53207

@ghost
Copy link

ghost commented May 27, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Caused by #53180, #53225
The original approach to install certificates didn't work because we don't have dotnet SDK, just runtime on some helix agents.
Fixes #53207

Author: pavelsavara
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@pavelsavara
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

-->
<PropertyGroup Condition="''$(TestPackages)' != 'true' and $(TargetsWindows)' != 'true' and '$(BrowserHost)' != 'windows'">
<!-- install SDK so that, we could use `dotnet dev-certs https`. -->
<IncludeDotNetCli>true</IncludeDotNetCli>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will IncludeDotNetCli be set for Windows as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can set this one in the bottom with HelixPreCommands?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if powershell works for windows, we do not need full SDK.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know but we still need IncludeDotNetCli

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then we don't need it at all?

@pavelsavara
Copy link
Member Author

/azp run runtime-libraries-mono outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ghost ghost locked as resolved and limited conversation to collaborators Jun 26, 2021
@pavelsavara pavelsavara deleted the pr_helix_install_dev_cert5 branch July 29, 2021 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Addition of "dotnet dev-certs" command makes all WASM work items time out
2 participants