Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mono] Add basic support for static virtual methods on interfaces #53465

Merged
merged 5 commits into from
Jun 1, 2021
Merged

[mono] Add basic support for static virtual methods on interfaces #53465

merged 5 commits into from
Jun 1, 2021

Conversation

vargaz
Copy link
Contributor

@vargaz vargaz commented May 29, 2021

No description provided.

@ghost
Copy link

ghost commented May 29, 2021

Tagging subscribers to this area: @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: vargaz
Assignees: -
Labels:

area-VM-meta-mono
Milestone: -

@vargaz
Copy link
Contributor Author

vargaz commented May 29, 2021 •
edited
Loading

There are still some test failures:

  • some of the generic tests only run with -O=-gshared. It looks like the problem is with function pointers to shared methods, i.e.
    Function Pointers to generic methods not working correctly mono/mono#20962
  • some tests expect ldtoken <BROKEN_TYPE> to throw an exception, but mono only detects some type load errors during vtable construction later
  • there are some failures in the interface variance tests which could be caused by existing problems with variance conflict resolution

@vargaz vargaz requested a review from BrzVlad as a code owner May 29, 2021 20:58
@lambdageek
Copy link
Member

I'm going to try to review by Tuesday. (of course everyone else is welcome to review, too.)

@vargaz vargaz merged commit 50639b8 into dotnet:main Jun 1, 2021
@vargaz vargaz deleted the abstract-static branch June 1, 2021 16:20
@lambdageek lambdageek mentioned this pull request Jun 1, 2021
Open
20 tasks
@ghost ghost locked as resolved and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lambdageek lambdageek lambdageek approved these changes

@CoffeeFlux CoffeeFlux Awaiting requested review from CoffeeFlux

@imhameed imhameed Awaiting requested review from imhameed

@SamMonoRT SamMonoRT Awaiting requested review from SamMonoRT

@thaystg thaystg Awaiting requested review from thaystg thaystg is a code owner

@BrzVlad BrzVlad Awaiting requested review from BrzVlad BrzVlad is a code owner

Assignees
No one assigned
Labels
area-VM-meta-mono
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vargaz @lambdageek