Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WSL checks and platform detection #53526

Merged
1 commit merged into from
Jun 1, 2021
Merged

Conversation

ViktorHofer
Copy link
Member

WSL1 isn't a supported build or execution environment for dotnet/runtime.
Because of that removing the checks and platform detection for it as
that code path isn't necessary for WSL2 anymore as it contains a fully
featured kernel which behaves just a like a usual Linux distro.

Fixes #18258

cc @ManickaP

WSL1 isn't a supported build or execution environment for dotnet/runtime.
Because of that removing the checks and platform detection for it as
that code path isn't necessary for WSL2 anymore as it contains a fully
featured kernel which behaves just a like a usual Linux distro.

Fixes dotnet#18258
@ViktorHofer ViktorHofer requested review from geoffkizer and wfurt June 1, 2021 12:45
@ViktorHofer ViktorHofer self-assigned this Jun 1, 2021
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@ghost
Copy link

ghost commented Jun 1, 2021

Hello @ViktorHofer!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 78fd895 into dotnet:main Jun 1, 2021
@ViktorHofer ViktorHofer deleted the RemoveWSL1Code branch June 1, 2021 14:50
@ManickaP
Copy link
Member

ManickaP commented Jun 2, 2021

I'm late to the party, but thanks @ViktorHofer 🥳

@ghost ghost locked as resolved and limited conversation to collaborators Jul 2, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build/test issues on WSL
4 participants