Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Incorrect order of checks for TypeBuilder GetConstructor and GetField method #53645

Merged
merged 16 commits into from
Nov 2, 2021
Merged

Fix: Incorrect order of checks for TypeBuilder GetConstructor and GetField method #53645

merged 16 commits into from
Nov 2, 2021

Commits on May 31, 2021

  1. Reorder checks for TypeBuilder.GetConstructor()

    @BartoszKlonowski
    BartoszKlonowski committed May 31, 2021
    Configuration menu
    Copy the full SHA
    d115433 View commit details
    Browse the repository at this point in the history

  2. Reorder checks for TypeBuilder.GetField()

    @BartoszKlonowski
    BartoszKlonowski committed May 31, 2021
    Configuration menu
    Copy the full SHA
    22cf90a View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Adjust unit test to reordered TypeBuilder checks

    @BartoszKlonowski
    BartoszKlonowski committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    f2efe72 View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2021

  1. Use 'not' keyword for pattern matching

    @BartoszKlonowski
    BartoszKlonowski committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    4940fc1 View commit details
    Browse the repository at this point in the history

  2. Apply the same Type checks for Mono 

    GetConstructor and GetField had the same incorrect checks order
comparing to GetMethod as in the CoreCLR.
To keep the consistent solution, Mono has also been adjusted.
    @BartoszKlonowski
    BartoszKlonowski committed Jun 14, 2021
    Configuration menu
    Copy the full SHA
    3472615 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2021

  1. Check whether a declaring type isn't type's generic definition

    @BartoszKlonowski
    BartoszKlonowski committed Jul 13, 2021
    Configuration menu
    Copy the full SHA
    fd50ec9 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2021

  1. Make generic type if contains generic parameters

    @BartoszKlonowski
    BartoszKlonowski committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    6fcfbf5 View commit details
    Browse the repository at this point in the history

  2. Suppres UnrecognizedReflectionPattern for GetField and GetConstructor

    @BartoszKlonowski
    BartoszKlonowski committed Jul 14, 2021
    Configuration menu
    Copy the full SHA
    f039dc9 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2021

  1. Move GetMethodType validation method at original order

    @BartoszKlonowski
    BartoszKlonowski committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    863b984 View commit details
    Browse the repository at this point in the history

  2. Test GetConstructor against throwing an exception

    @BartoszKlonowski
    BartoszKlonowski committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    f806283 View commit details
    Browse the repository at this point in the history

  3. Fix: copy-paste error 'type' -> 'constructor'

    @BartoszKlonowski
    BartoszKlonowski committed Jul 26, 2021
    Configuration menu
    Copy the full SHA
    70f45eb View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2021

  1. Align Mono and CoreCLR with nameof for GetConstructor

    @BartoszKlonowski
    BartoszKlonowski committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    b2c2b4a View commit details
    Browse the repository at this point in the history

  2. Use type for argument exception and test against type parameter

    @BartoszKlonowski
    BartoszKlonowski committed Jul 27, 2021
    Configuration menu
    Copy the full SHA
    98036aa View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Merge remote-tracking branch 'upstream/main' into fix-typebuilder-che… 

    …cks-order
    @eerhardt
    eerhardt committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    474a10b View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2021

  1. Get tests passing on both coreclr and mono. 

    Ensure checks are consistent across GetConstructor, GetField, and GetMethod for both coreclr and mono.
    @eerhardt
    eerhardt committed Oct 6, 2021
    Configuration menu
    Copy the full SHA
    23795a0 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. Fix mono exception messages to use SR resources.

    @eerhardt
    eerhardt committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    f7ed1ac View commit details
    Browse the repository at this point in the history