Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multi-arch install locations #53763

Merged
merged 23 commits into from
Jun 23, 2021
Merged

Add support for multi-arch install locations #53763

merged 23 commits into from
Jun 23, 2021

Commits on Jun 22, 2021

  1. Add support for multiple architectures inside install_locations

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    89c6a26 View commit details
    Browse the repository at this point in the history

  2. Fix traces

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    fd767f1 View commit details
    Browse the repository at this point in the history

  3. Add install_location tests

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    1de63dc View commit details
    Browse the repository at this point in the history

  4. Message printed to stderr

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    48be319 View commit details
    Browse the repository at this point in the history

  5. Set arch specific DOTNET_ROOT env var

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    f1a2b7d View commit details
    Browse the repository at this point in the history

  6. Inline pal::to_lower/upper

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    7fe0238 View commit details
    Browse the repository at this point in the history

  7. Update tests 

    Move to_lower, to_upper to utils
Add MultiArchInstallLocation tests
    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    e40c618 View commit details
    Browse the repository at this point in the history

  8. Update tests

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    98814ea View commit details
    Browse the repository at this point in the history

  9. Sort usings

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    3a40dfd View commit details
    Browse the repository at this point in the history

  10. PR Feedback

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    e1d55c9 View commit details
    Browse the repository at this point in the history

  11. Fix trace

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    9602d92 View commit details
    Browse the repository at this point in the history

  12. Fail if DOTNET_ROOT_ARCH is defined but path doesn't exist 

    Modify trace error message
    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c1b7af2 View commit details
    Browse the repository at this point in the history

  13. PR feedback

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    104357c View commit details
    Browse the repository at this point in the history

  14. Fallback to DOTNET_ROOT on win32 

    Warn instead of error
Change from vector to fgets
    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    3280fff View commit details
    Browse the repository at this point in the history

  15. Add tests with really long install location path 

    Move get_line_from_file to unix pal
    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    8236390 View commit details
    Browse the repository at this point in the history

  16. Fix tests

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    190bc43 View commit details
    Browse the repository at this point in the history

  17. Make consistent use of str assign

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    bbc05c8 View commit details
    Browse the repository at this point in the history

  18. PR feedback

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    e5b18e5 View commit details
    Browse the repository at this point in the history

  19. Fix unix pal

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    53edd07 View commit details
    Browse the repository at this point in the history

  20. Test

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    c9ad207 View commit details
    Browse the repository at this point in the history

  21. Remove nonsense string

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    6ae64aa View commit details
    Browse the repository at this point in the history

  22. Put optional arguments last 

    Check the rid of the launched process
    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    a04b846 View commit details
    Browse the repository at this point in the history

  23. Pass RID

    Mateo Torres Ruiz committed Jun 22, 2021
    Configuration menu
    Copy the full SHA
    2402b61 View commit details
    Browse the repository at this point in the history