Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seal nested classes #54196

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Seal nested classes #54196

merged 1 commit into from
Jun 15, 2021

Conversation

davidfowl
Copy link
Member

@ghost
Copy link

ghost commented Jun 15, 2021

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes https://github.com/dotnet/efcore/blob/36dd65ca8c309541e53a4b5a2f2124db5695fda6/test/EFCore.Design.Tests/DesignApiConsistencyTest.cs#L30

Author: davidfowl
Assignees: -
Labels:

area-Extensions-Hosting

Milestone: -

@davidfowl
Copy link
Member Author

@danmoseley can we turn auto merge on for this repo?

@ghost
Copy link

ghost commented Jun 15, 2021

Hello @stephentoub!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@eerhardt
Copy link
Member

can we turn auto merge on for this repo?

We use the 'auto-merge' label. To use GitHub's auto-merge feature we would need to make the runtime CI leg "required", which means only admins could merge PRs when the runtime CI leg failed.

@davidfowl
Copy link
Member Author

I see

@davidfowl
Copy link
Member Author

What is going on with the builds...

@davidfowl davidfowl merged commit dfcaf41 into main Jun 15, 2021
@eerhardt eerhardt deleted the davidfowl/seal-nestedclasses branch June 15, 2021 14:26
@ghost ghost locked as resolved and limited conversation to collaborators Jul 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants