Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail COM CoClass creation during construction instead of during jitting #54508

Merged
merged 3 commits into from
Jun 22, 2021

Conversation

jkoritzinsky
Copy link
Member

Fail COM CoClass creation during construction instead of during jitting (which wouldn't fail when the assembly had been run through crossgen2). Also, make the behavior consistent across platforms.

Fixes #54379

…ng (which wouldn't fail when the assembly had been run through crossgen2)
@jkotas
Copy link
Member

jkotas commented Jun 21, 2021

Re-enable the test disabled in #54435

@jkoritzinsky
Copy link
Member Author

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jkoritzinsky
Copy link
Member Author

Failure is a known infra issue. Merging this in.

@jkoritzinsky jkoritzinsky merged commit 2a61c25 into dotnet:main Jun 22, 2021
@jkoritzinsky jkoritzinsky deleted the comobj-new-fail branch June 22, 2021 16:32
@ghost ghost locked as resolved and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: Interop\\COM\\NETClients\\ComDisabled\\NETClientComDisabled\\NETClientComDisabled.cmd
4 participants