Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dotnet\packs\Microsoft.NET.Runtime.WebAssembly.Sdk\6.0.0-preview.7.21321.15\Sdk\WasmApp.Native.targets(342,5): error : Could not find AOT cross compiler at $(_MonoAotCrossCompilerPath)=
Make sure this is set for the aot code path.
Background:
This wasn't getting caught by the
Wasm.Build.Tests
because they rely on theruntime
repo's infrastructure to get all the bits required for building, which includes the cross compiler. So, the correct properties are already set up.In case of workloads though, all this information comes from the packs, including the cross compiler path. There was a recent change to use an item for cross compiler paths(because on other platforms, there could be more than one available cross compiler, eg. android), instead of a property.
So, the targets were updated to extract the path in case of wasm
Sdk.props
for the cross compiler, it comes into play only with workloads!I have an upcoming PR, which enables running
Wasm.Build.Tests
with workloads, and that would be able to catch this bug.