Fix MonoCrossAOT.UnixFilePermissions for wasm #54693
Conversation
We introduced Microsoft.NETCore.App.MonoCrossAOT.UnixFilePermissions.xml in dotnet#54501 to make sure the right permissions are set when installing AOT compiler workload packs. We hardcoded the list to include mono-aot-cross, llc, and opt. However, in wasm's case they only have mono-aot-cross. This change makes the xml file a template and only includes mono-aot-cross for browser and all three for the other configurations. Fixes dotnet#54612
steveisok
requested review from
akoeplinger,
mdh1418,
directhex,
lewing and
radical
|
Official build where we need to validate the change. AOT Compiler packs are only generated here. https://dev.azure.com/dnceng/internal/_build/results?buildId=1204648&view=results |
|
This specifies the files to be included, IIUC: Can we get execute permissions from those files, and use that to populate the xml? |
you could do something like all the files in tools without an extension pretty easily |
src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.MonoCrossAOT.sfxproj
Show resolved
Hide resolved
Will that happen as part of some step there, or do we manually download, and check permissions? |
Has to be manual for now. |
|
@radical and I validated a sample of the linux and osx packages have the right permissions. Also, the official build completed. |
ghost
locked as resolved and limited conversation to collaborators
We introduced Microsoft.NETCore.App.MonoCrossAOT.UnixFilePermissions.xml in #54501 to make sure the right permissions are set when installing AOT compiler workload packs. We hardcoded the list to include mono-aot-cross, llc, and opt. However, in wasm's case they only have mono-aot-cross.
This change makes the xml file a template and only includes mono-aot-cross for browser and all three for the other configurations.
Fixes #54612