Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remote server redirect and decompression tests to HttpClientHandlerTest.RemoteServer.cs #54738

Merged
merged 2 commits into from
Jun 26, 2021

Conversation

geoffkizer
Copy link
Contributor

Contributes to #30205

These classes currently contain a mix of loopback server tests and remote server tests. Move the remote server tests to HttpClientHandlerTest.RemoteServer.cs to prevent test run redundancy and make it easier to convert the remaining tests to be version-agnostic.

There are no intentional test changes here, just moving stuff between files.

@ghost
Copy link

ghost commented Jun 25, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #30205

These classes currently contain a mix of loopback server tests and remote server tests. Move the remote server tests to HttpClientHandlerTest.RemoteServer.cs to prevent test run redundancy and make it easier to convert the remaining tests to be version-agnostic.

There are no intentional test changes here, just moving stuff between files.

Author: geoffkizer
Assignees: -
Labels:

area-System.Net.Http

Milestone: -

@geoffkizer
Copy link
Contributor Author

@dotnet/dnceng I seem to be getting weird build errors in the net48 x86 release build that look unrelated to my change (I haven't touched the file it's referring to). Any idea what's up here?

https://github.com/dotnet/runtime/pull/54738/checks?check_run_id=2918553410

@MattGal
Copy link
Member

MattGal commented Jun 26, 2021

@dotnet/dnceng I seem to be getting weird build errors in the net48 x86 release build that look unrelated to my change (I haven't touched the file it's referring to). Any idea what's up here?

https://github.com/dotnet/runtime/pull/54738/checks?check_run_id=2918553410

Perhaps you need to merge main in? That's suspiciously timed with fc4a427

@geoffkizer
Copy link
Contributor Author

Yeah that must be it. Thanks.

@geoffkizer geoffkizer merged commit 31de746 into dotnet:main Jun 26, 2021
@geoffkizer geoffkizer deleted the moveremoteservertests branch June 26, 2021 04:10
@karelz karelz added this to the 6.0.0 milestone Jul 15, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Aug 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants