-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use GT_ARR_ELEM as a location/value #54780
Don't use GT_ARR_ELEM as a location/value #54780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cc @dotnet/jit-contrib
Is it surprising there are no diffs? Was that dead code? It looks like GT_ARR_ELEM represents an address, not an array element. For that, we'll have a wrapping IND/OBJ node. Seems like the comment above GenTreeArrElem should clarify. Should GT_ARR_ELEM return false from What about the appearance in |
Yes, that is my understanding. It appears to me that a very long time ago
Fixed. Perhaps the best thing to do would be to rename it
I think those usages are correct as |
Looks like it needs a formatting fix (maybe rebase on top of #55320 and run jit-format just to be sure). |
It represents an address. No diffs.
20d6956
to
fd8421a
Compare
Rebased, we'll see what the CI thinks. |
1) |
It represents an address.
No diffs.