One shot CFB #55428
One shot CFB #55428
Conversation
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @bartonjs, @vcsjones, @krwq, @GrabYourPitchforks Issue DetailsThis implements CFB one shots. Remaining work:
Closes #2406
|
|
This is draft to get feedback from CI since I am still missing a working Windows machine (but should be back up in the next day or two). |
vcsjones
force-pushed
the
2406-one-shot-cfb
branch
from
50eae65
to
429524c
Compare
| @@ -256,6 +256,9 @@ public abstract partial class SymmetricAlgorithm : System.IDisposable | |||
| public byte[] DecryptCbc(byte[] ciphertext, byte[] iv, System.Security.Cryptography.PaddingMode paddingMode = System.Security.Cryptography.PaddingMode.PKCS7) { throw null; } | |||
| public byte[] DecryptCbc(System.ReadOnlySpan<byte> ciphertext, System.ReadOnlySpan<byte> iv, System.Security.Cryptography.PaddingMode paddingMode = System.Security.Cryptography.PaddingMode.PKCS7) { throw null; } | |||
| public int DecryptCbc(System.ReadOnlySpan<byte> ciphertext, System.ReadOnlySpan<byte> iv, System.Span<byte> destination, System.Security.Cryptography.PaddingMode paddingMode = System.Security.Cryptography.PaddingMode.PKCS7) { throw null; } | |||
| public byte[] DecryptCfb(byte[] ciphertext, byte[] iv, System.Security.Cryptography.PaddingMode paddingMode = System.Security.Cryptography.PaddingMode.None, int feedbackSizeInBits = 8) { throw null; } | |||
There was a problem hiding this comment.
All of these API additions slightly deviate from the approved API: the feedbackSizeBits was changed to feedbackSizeInBits. This matches the same convention that was settled on in #45003 (comment).
|
Will re-open this later. Realized there is a bit more left to get CNG working the way it should. |
ghost
locked as resolved and limited conversation to collaborators
This implements CFB one shots.
Remaining work:
Closes #2406