Look up the ICustomMarshaler implementation methods based on runtime type #55439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ime type of the object returned from GetInstance, instead of using the type that was declared in the marshalling info. These two types can differ, which can cause incorrect methods to be called at runtime if the runtime type has a different vtable layout than the method's parent type. Contributes to dotnet#39606
|
Can you add a test for this? |
|
Some of our tests actually already test this, and just happened to work. I’ll try to add a test that would crash previously. |
elinor-fung
approved these changes
Jul 12, 2021
|
503 package errors are https://github.com/dotnet/core-eng/issues/13691 |
|
Docker failure and Android failure are both network blips. Merging. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Look up the ICustomMarshaler implementation methods based on the runtime type of the object returned from GetInstance, instead of using the type that was declared in the marshalling info.
These two types can differ, which can cause incorrect methods to be called at runtime if the runtime type has a different vtable layout than the method's parent type.
Contributes to #39606