StringSegment behavior

[hrrrrustic]

fix #45021
fix #53727

[ghost]

Tagging subscribers to this area: @eerhardt, @maryamariyan
See info in area-owners.md if you want to be subscribed.

Issue Details

---

fix #45021
fix #53727

Author:	hrrrrustic
Assignees:	-
Labels:	area-Extensions-Primitives
Milestone:	-

[GrabYourPitchforks]

@maryamariyan You marked #45021 as up-for-grabs but never specified what you believe the correct behavior should be: consistently return -1 or consistently throw an exception.

/cc @halter73

[hrrrrustic]

I guess -1 is the correct way as it described in all of this methods docs 😄

runtime/src/libraries/Microsoft.Extensions.Primitives/src/StringSegment.cs

Line 447 in 57bfe47

/// <returns>The zero-based index position of <paramref name="c"/> from the beginning of the <see cref="StringSegment"/> if that character is found, or -1 if it is not.</returns>

runtime/src/libraries/Microsoft.Extensions.Primitives/src/StringSegment.cs

Line 504 in 57bfe47

/// was found; -1 if no character in <paramref name="anyOf"/> was found.</returns>

runtime/src/libraries/Microsoft.Extensions.Primitives/src/StringSegment.cs

Line 571 in 57bfe47

/// <returns>The zero-based index position of value if that character is found, or -1 if it is not.</returns>

[eerhardt]

I think this looks good. @GrabYourPitchforks - any thoughts/concerns?

[eerhardt]

Linq.Expression failures are #55536. Merging.

[eerhardt]

Thanks @hrrrrustic for the contribution here!