-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove sourceFullPath from Unix FileSystem.MoveDirectory exception #55658
Conversation
Switched method from a private protection level to an internal protection level. Also removed trailing whitespace.
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsSummaryRemoves the For reference, see the first possible solution for this problem (#50833 (comment)):
Other minor fixes
Fixes #50833
|
For reference, not really. The compiler's still going to generate cascading ifs, similar to the original source code: |
src/libraries/System.Private.CoreLib/src/System/IO/FileSystem.Windows.cs
Outdated
Show resolved
Hide resolved
Thanks. |
Summary
Removes the
sourceFullPath
argument from the exception thrown when a destination file path forDirectory.Move
has a parent that doesn't exist in Unix. This matches the functionality of Windows. The results should be more consistent and less confusing exceptions from theDirectory.Move
method on both Unix and Windows platforms.For reference, see the first possible solution for this problem #50833 (comment):
Other minor fixes
Fixes #50833