-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sigaction with SIG_DFL and SA_SIGINFO. #55673
Conversation
@janvorli, could you review this one as well? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo the nit.
// macOS can return sigaction with SIG_DFL and SA_SIGINFO. | ||
// SA_SIGINFO means we should use sa_sigaction, but here we want to check sa_handler. | ||
// So we ignore SA_SIGINFO when sa_sigaction and sa_handler are at the same address. | ||
return (&action->sa_handler == (void*)&action->sa_sigaction || !IsSaSigInfo(action)) && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit - can you please add ( )
to explicitly express the precedence in all the composite conditions? It is a preferred style in this codebase. Like this:
return ((&action->sa_handler == (void*)&action->sa_sigaction) || !IsSaSigInfo(action)) &&
(action->sa_handler == SIG_DFL));
Linux failure is a SIGABRT in the Http tests on Linux. I am not sure how to resolve the frames:
Seems unlikely it is related. |
Because this is breaking Xamarin iOS, and tomorrow is Preview 7 sync, I will merge this and @tmds can perhaps fix the code formatting separately. I hope that is OK. I am assuming the Http crash is not related. |
Oh, I didn't see that one of the arm64 configs timed out. I'll rerun that. |
Hello @danmoseley! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Github and azdo are out of sync. Looks like the build has finished successfully. |
Fixes #55645
@rolfbjarne @lambdageek @stephentoub ptal