-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update System.Net.Security Telemetry tests #55910
Conversation
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsUpdated the NetSecurity telemetry tests to use a Updated the product instrumentation to use a real async method instead of Fixes #42613
|
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.Implementation.cs
Outdated
Show resolved
Hide resolved
@MihaZupan is it ready for re-review from @stephentoub? |
Yes. I pushed the change to always return a |
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/src/System/Net/Security/SslStream.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Hello @MihaZupan! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Updated the NetSecurity telemetry tests to use a
WaitForEventCounters
helper instead of relying on a racyTask.Delay
.Enhanced the test to also check for correct ActivityIds.
Updated the product instrumentation to use a real async method instead of
.ContinueWith
to ensure events fire under the right ExecutionContext. Similar to the fix inNameResolution
from #42188 (#41670 (comment)).Fixes #42613