-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix illumos build regressions #55916
Conversation
am11
commented
Jul 19, 2021
- gcc looks for fallthrough or break in morph (we could move the break out of condition, but there are a few gotos to that case which I am not sure might have sideeffect, so i kept it simple).
- SHM_ANON is not available in illumos/Solaris libc (POSIX does not require it), so manually generate name using timespec for shm_open() call.
- in line with previous fixes made for statfs, SunOS-like OS has deprecated statfs in favor of statvfs. The f_type does not return magic number as other Unices. The more reliable way is to get the stringly name from f_basetype and then resolve the enum value. Assuming performance is not a concern for DriveInfo, kept it simple.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
0945a73
to
638ffb9
Compare
cc @janvorli, docker run -e ROOTFS_DIR=/crossrootfs/x64 -v $(pwd):/runtime \
mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-18.04-cross-illumos-20210714135645-f13d79e \
/runtime/build.sh -arch x64 -os illumos -cross -gcc (entire build) continue to succeed with this patch. |
The changes look good, but I'd like some libraries folks to review the related part of the change. @stephentoub could you please take a look or add someone else to review this? |
661bd03
to
810b4ae
Compare
@stephentoub, @adamsitnik. the library change for official platforms has no diffs in IL or PAL binaries. I have split a partial class and updated the native implementation using existing macros, which indicates if system has a legacy |
Sorry, I missed the notification when I was tagged. Looking now... |
src/libraries/Common/src/Interop/Unix/System.Native/Interop.UnixFileSystemTypes.statvfs.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Stephen Toub <stoub@microsoft.com>
Windows x86 failure is unrelated (and fixed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System.IO part LGTM.
@am11 big thanks for another great contribution! And kudos for adding extra file system types to our existing enumeration!
Co-authored-by: Adam Sitnik <adam.sitnik@gmail.com>