Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0-preview7] Fix System.Data.SqlClient dependency version on compat pack #56035

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jul 20, 2021

Backport of #55956 to release/6.0-preview7

/cc @safern

Customer Impact

They can't reference the package as it fails with:

Microsoft.Windows.Compatibility 6.0.0-preview.6.21352.12 nuget package depends on System.Data.SqlClient 4.8.2-preview.6.21352.12 which is not available on nuget.org.

Testing

Manually tested that the dependency is correct now and we also enabled package testing on CI to ensure the package can be restored correctly.

Risk

Low.

@ghost
Copy link

ghost commented Jul 20, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #55956 to release/6.0-preview7

/cc @safern

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@safern safern added the Servicing-consider Issue for next servicing release review label Jul 20, 2021
@safern safern added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Jul 20, 2021
@safern safern closed this Jul 21, 2021
@safern safern reopened this Jul 21, 2021
@safern
Copy link
Member

safern commented Jul 21, 2021

Failures are unrelated.

@safern safern merged commit ba08d9a into release/6.0-preview7 Jul 21, 2021
@safern safern deleted the backport/pr-55956-to-release/6.0-preview7 branch July 21, 2021 04:46
@ghost ghost locked as resolved and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants