HTTP3: Fix issue with GOAWAY handling and implement graceful shutdown logic in Http3LoopbackServer #56134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsFixes #55025 Fix an issue where we are not properly handling a GOAWAY frame because we think we've seen one previously, even though we haven't. Add graceful shutdown logic to Http3LoopbackServer. Related QUIC tests and fixes.
|
geoffkizer
requested review from
wfurt,
ManickaP and
CarnaViire
and removed request for
ManickaP
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
CarnaViire
reviewed
Jul 22, 2021
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs
Outdated
Show resolved
Hide resolved
CarnaViire
reviewed
Jul 22, 2021
src/libraries/System.Net.Quic/tests/FunctionalTests/QuicConnectionTests.cs
Show resolved
Hide resolved
CarnaViire
reviewed
Jul 22, 2021
added 4 commits
July 23, 2021 17:59
…tion is closed/disposed, and related product fixes
…p3LoopbackConnection
geoffkizer
force-pushed
the
http3loopbackserver
branch
from
472d07c to
07a4c0a
Compare
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I addressed the feedback -- please take a look. |
|
Failures look unrelated |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #55025
Fixes #55508
Fix an issue where we are not properly handling a GOAWAY frame because we think we've seen one previously, even though we haven't.
Add graceful shutdown logic to Http3LoopbackServer.
Related QUIC tests and fixes.