Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make LocalEndPointTest and some Connect tests non-parallel #56399

Merged
merged 4 commits into from
Jul 30, 2021

Conversation

antonfirsov
Copy link
Member

@antonfirsov antonfirsov commented Jul 27, 2021

There is some chance that sockets in these tests are connecting to, or being connected by sockets of other, unrelated parallel tests.

Fixes #52141. Hopefully fixes #55709 too, although I don't have a proof that the reported socket error can be the result of unrelated accepts. We can reopen the issues if we'll keep experiencing them in the CI.

Fixes #52141
Fixes #55709
Fixes #56042

@ghost
Copy link

ghost commented Jul 27, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

There is some chance that these tests are connected/being connected by sockets of unrelated tests.

Fixes #52141. Hopefully fixes #55709 too, although I don't have a proof that the reported socket error can be the result of unrelated accepts. We can reopen the issues if we'll keep experiencing them in the CI.

Author: antonfirsov
Assignees: -
Labels:

area-System.Net.Sockets

Milestone: -

@wfurt
Copy link
Member

wfurt commented Jul 27, 2021

do you know how much time it added to complete run @antonfirsov? (just curious)

@antonfirsov
Copy link
Member Author

< 100 ms for LocalEndPointTest. Haven't checked the Connect tests.

@karelz
Copy link
Member

karelz commented Jul 29, 2021

@antonfirsov I updated top post with "Fixes #number" to trigger auto-close when this is merged.

@karelz
Copy link
Member

karelz commented Jul 30, 2021

Test failures seem to be unrelated: (re-running just in case)

Failed to retrieve information about 'System.ComponentModel.TypeConverter.TestData' from remote source 'https://pkgs.dev.azure.com/dnceng/9ee6d478-d288-47f7-aacc-f6e6d082ae6d/_packaging/1a5f89f6-d8da-4080-b15f-242650c914a8/nuget/v3/flat2/system.componentmodel.typeconverter.testdata/index.json'.
   at NuGet.Protocol.HttpFileSystemBasedFindPackageByIdResource.FindPackagesByIdAsync(String id, SourceCacheContext cacheContext, ILogger logger, CancellationToken cancellationToken) in NuGet.Protocol.dll:token 0x6000392+0x2dc
   at NuGet.Protocol.HttpFileSystemBasedFindPackageByIdResource.EnsurePackagesAsync(String id, SourceCacheContext cacheContext, ILogger logger, CancellationToken cancellationToken) in NuGet.Protocol.dll:token 0x6000391+0x13f
   at NuGet.Protocol.HttpFileSystemBasedFindPackageByIdResource.DoesPackageExistAsync(String id, NuGetVersion version, SourceCacheContext cacheContext, ILogger logger, CancellationToken cancellationToken) in NuGet.Protocol.dll:token 0x6000390+0x17c
   at NuGet.Commands.SourceRepositoryDependencyProvider.FindLibraryCoreAsync(LibraryRange libraryRange, SourceCacheContext cacheContext, ILogger logger, CancellationToken cancellationToken) in NuGet.Commands.dll:token 0x6000459+0x379
   at NuGet.Commands.SourceRepositoryDependencyProvider.<>c__DisplayClass19_0.<<FindLibraryAsync>b__0>d.MoveNext() in NuGet.Commands.dll:token 0x6000a2d+0xb6

@antonfirsov antonfirsov merged commit 6d79c7e into dotnet:main Jul 30, 2021
@karelz karelz added this to the 6.0.0 milestone Aug 17, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.