-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make LocalEndPointTest and some Connect tests non-parallel #56399
Make LocalEndPointTest and some Connect tests non-parallel #56399
Conversation
Tagging subscribers to this area: @dotnet/ncl Issue DetailsThere is some chance that these tests are connected/being connected by sockets of unrelated tests. Fixes #52141. Hopefully fixes #55709 too, although I don't have a proof that the reported socket error can be the result of unrelated accepts. We can reopen the issues if we'll keep experiencing them in the CI.
|
do you know how much time it added to complete run @antonfirsov? (just curious) |
|
@antonfirsov I updated top post with "Fixes #number" to trigger auto-close when this is merged. |
Test failures seem to be unrelated: (re-running just in case)
|
There is some chance that sockets in these tests are connecting to, or being connected by sockets of other, unrelated parallel tests.
Fixes #52141. Hopefully fixes #55709 too, although I don't have a proof that the reported socket error can be the result of unrelated accepts. We can reopen the issues if we'll keep experiencing them in the CI.
Fixes #52141
Fixes #55709
Fixes #56042