disable test parallelization for http3 #56413
Conversation
wfurt
added
area-System.Net.Http
test-enhancement
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsWhile some of the CI failures are not fully understood, CPU load and #55979 may be contributing factor.
|
| @@ -3143,20 +3143,23 @@ public sealed class SocketsHttpHandler_HttpClientHandler_Cancellation_Test_Http2 | |||
| } | |||
|
|
|||
| [ConditionalClass(typeof(HttpClientHandlerTestBase), nameof(IsMsQuicSupported))] | |||
| [Collection("NoParallelTests")] | |||
There was a problem hiding this comment.
Nit:
| [Collection("NoParallelTests")] | |
| [Collection(nameof(NoParallelTests))] |
There was a problem hiding this comment.
Technically, this is name of the collection, not name of the class right?
[CollectionDefinition("NoParallelTests", DisableParallelization = true)]
It so happen we name them the same.
There was a problem hiding this comment.
Yes, but it still helps IMO by binding the string constant to a symbol name in the C# compilation. (Harder to make a typo assuming we may have more of these.)
ghost
locked as resolved and limited conversation to collaborators
While some of the CI failures are not fully understood, CPU load and #55979 may be contributing factor.
As mitigation agreed with the team, we will for now run HTTP3 tests without parallelism and all the HTTP3 tests will run last one by one. It does not seems to add significant delay to overall duration.