Assert if we find undefined use during interval validation #56439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-CodeGen-coreclr
|
@dotnet/jit-contrib |
BruceForstall
approved these changes
Jul 28, 2021
|
@kunalspathak does this close #56237 ? |
No @JulieLeeMSFT - This PR is unrelated to #56237. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During
validateIntervals(), we keep track of definition and lastuse of RefPositions. After we encounterlastUseRefPosition, we do not expect to see any otherRefPositionwith "use". If we see it, we were simply logging it under JitDump. The only scenario in which this can happen is the "use" RefPosition isEarlier, whenever we find a "use" refposition without definition, we were simply logging it under JitDump. It should only happen if the "use" refposition is in a different block then the previous "lastuse" refposition. I fixed it and enabled an assert when this doesn't happen.
Fixes: #45238