Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable System.IO.FileSystem.DriveInfoTests.DriveInfoUnixTests.PropertiesOfValidDrive on Android #56462

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Re-enable System.IO.FileSystem.DriveInfoTests.DriveInfoUnixTests.PropertiesOfValidDrive on Android #56462

merged 1 commit into from
Jul 28, 2021

Conversation

MaximLipnin
Copy link
Contributor

Contributes to #42548.

Based on Alexander's suggestion #42209 (comment)

@ghost
Copy link

ghost commented Jul 28, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

Contributes to #42548.

Based on Alexander's suggestion #42209 (comment)

Author: MaximLipnin
Assignees: -
Labels:

area-System.IO
Milestone: -

adamsitnik
adamsitnik approved these changes Jul 28, 2021
View reviewed changes
Copy link
Member

@adamsitnik adamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @MaximLipnin !

@adamsitnik adamsitnik added this to the 6.0.0 milestone Jul 28, 2021
@steveisok steveisok merged commit fe4d5cf into dotnet:main Jul 28, 2021
@MaximLipnin MaximLipnin deleted the reenable_driveinfo_test_on_android branch July 28, 2021 18:20
@MaximLipnin MaximLipnin mentioned this pull request Jul 28, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Aug 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adamsitnik adamsitnik adamsitnik approved these changes

@mdh1418 mdh1418 mdh1418 approved these changes

@directhex directhex Awaiting requested review from directhex

@steveisok steveisok Awaiting requested review from steveisok

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

Assignees
No one assigned
Labels
area-System.IO
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MaximLipnin @adamsitnik @mdh1418 @steveisok