-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build C++/CLI tests as .NET Core C++/CLI #56502
Conversation
… -DCPP_CLI_LIVE_REF_ASSEMBLIES=1` to the test build script.
Tagging subscribers to this area: @hoyosjs Issue DetailsUpdate our C++/CLI tests to build with the They'll normally build against the ref pack used to build the managed portions of the repo, but by passing I've validated locally that the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add documentation for the way to build against live build. Perhaps in one of the test document markdown files or under the interop folder?
I agree with @AaronRobinsonMSFT unless this is documented, this work will not be found or understood in the future when we need it. Please add something to our markdown. |
Why can't we make this the default? |
We can't make this the default since in our current CI build, we build the native tests as part of the CoreCLR product build. So either we build the ref assemblies an extra time in the CoreCLR build which adds more time for every CI run, or we have to re-organize the build, which is a much higher cost than is budgeted for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The error handling is perfect. Much appreciated!
…ce MSVC uses it if it exists.
Hello @jkoritzinsky! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Update our C++/CLI tests to build with the
/clr:netcore
flag.They'll normally build against the ref pack used to build the managed portions of the repo, but by passing
-cmakeargs -DCPP_CLI_LIVE_REF_ASSEMBLIES=1
on the command line for thesrc/test/build.cmd
script, developers can build them against the in-repo ref pack.I've validated locally that the
CPP_CLI_LIVE_REF_ASSEMBLIES
option repros the issues seen with static abstract interface members in WPF.