Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MetricsEventSource tests #56654

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Fix MetricsEventSource tests #56654

merged 1 commit into from
Aug 4, 2021

Conversation

noahfalk
Copy link
Member

Fixes #55313

The metrics test has to collect different events that
update counters in a specific interval of time. Previously
those intervals were 1 second long but ARM64 appears to
run slowly enough that some of the events didn't complete
until 2 seconds had passed.

I increased the intervals to 5 seconds each. We could go
longer to reduce the risk further, but I am trying not to
make the tests take overly long. The full set of tests uses
~45 intervals.

@noahfalk
Fix MetricsEventSource tests
1cadd17 
Fixes dotnet#55313

The metrics test has to collect different events that
update counters in a specific interval of time. Previously
those intervals were 1 second long but ARM64 appears to
run slowly enough that some of the events didn't complete
until 2 seconds had passed.

I increased the intervals to 5 seconds each. We could go
longer to reduce the risk further, but I am trying not to
make the tests take overly long.
@noahfalk
Copy link
Member Author

/azp list

@azure-pipelines
Copy link

CI/CD Pipelines for this repository:

@noahfalk
Copy link
Member Author

/azp runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Command 'runtime-libraries-coreclr' is not supported by Azure Pipelines.

Supported commands
  • help:
    • Get descriptions, examples and documentation about supported commands
    • Example: help "command_name"
  • list:
    • List all pipelines for this repository using a comment.
    • Example: "list"
  • run:
    • Run all pipelines or specific pipelines for this repository using a comment. Use this command by itself to trigger all related pipelines, or specify specific pipelines to run.
    • Example: "run" or "run pipeline_name, pipeline_name, pipeline_name"
  • where:
    • Report back the Azure DevOps orgs that are related to this repository and org
    • Example: "where"

See additional documentation.

@noahfalk
Copy link
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@noahfalk
Copy link
Member Author

noahfalk commented Aug 2, 2021

Hit unrelated outerloop issues:
System.Cryptography - #734
System.ServiceProcess.Tests - #56679
System.Runtime.Tests - #56567

@noahfalk noahfalk requested a review from josalem August 2, 2021 03:48
josalem
josalem approved these changes Aug 2, 2021
View reviewed changes
Copy link
Contributor

@josalem josalem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@noahfalk noahfalk merged commit 2360161 into dotnet:main Aug 4, 2021
@eiriktsarpalis eiriktsarpalis mentioned this pull request Aug 14, 2021
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josalem josalem josalem approved these changes

Assignees
No one assigned
Labels
area-System.Diagnostics.Metric
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test failure:System.Diagnostics.Metrics.Tests.MetricEventSourceTests.EventSourceFiltersInstruments
2 participants
@noahfalk @josalem