Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README.md for archived runtime packages #570

Merged
merged 2 commits into from
Dec 5, 2019
Merged

Conversation

cston
Copy link
Member

@cston cston commented Dec 5, 2019

@cston
Copy link
Member Author

cston commented Dec 5, 2019

cc @jaredpar, @stephentoub, @karelz, @danmosemsft

@ViktorHofer
Copy link
Member

@ericstj should we consider harvesting (some of those) instead?

@jaredpar
Copy link
Member

jaredpar commented Dec 5, 2019

should we consider harvesting (some of those) instead?

Harvesting?

# Microsoft.CSharp package

We are not accepting feature contributions to Microsoft.CSharp.
The package is effectively archived.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is correct. Archived implies no changes whatsoever.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase "effectively archived" is being applied to all of our code bases where we're only taking servicing level fixes. It's how we describe the old corefx, coreclr and core-setup repositories for example. These libraries fit into that theme.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. It's up to you what language you use, but it came across as hyperbole to me when the following statement seemed to contradict it. To me, "effectively archived" makes sense for repositories where the code has moved somewhere else for the latest release, it makes less sense when the library is still building out of the codebase and you've just racheted up the bar: nothing has been archived it just has a higher bar.

@ericstj
Copy link
Member

ericstj commented Dec 5, 2019

Harvesting?

AKA redistributing old binaries in new packages.

@ericstj should we consider harvesting (some of those) instead?

No, since the product still ships these and we support them we need to continue to build them and not extend the lifetime of past servicing branches past the product lifecycle. We should only stop building things that are no longer part of the product.

@@ -0,0 +1,8 @@
# System.Dynamic.Runtime package
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package here is a misnomer: we don't produce a package for this. It's only in the shared framework. Should this say "library" instead? Same applies to System.Linq.Expressions.

@stephentoub stephentoub merged commit 4c163ba into dotnet:master Dec 5, 2019
@ltrzesniewski
Copy link
Contributor

I'd still like https://github.com/dotnet/corefx/issues/16287 to be fixed in System.Linq.Expressions since it's a regression from the .NET Framework. Would you be willing to consider this?

@jaredpar
Copy link
Member

jaredpar commented Dec 5, 2019

@ltrzesniewski

Agree with @danmosemsft comment there:

However bringing back a method that was previously present in desktop may fall under the "regressions" category described in that issue.

If there was a solid plan for how to bring this back on top of the feature set of .NET Core (given the old emit technology wasn't ported to desktop) then we'd be willing to consider a pull request for that.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
radical pushed a commit to radical/runtime that referenced this pull request Jul 7, 2022
- The port wasn't opened on the device so the tunnel was never connected properly
- Fixing multiple timestamps in logs (cascades of callback/aggregated logs)
- Fixing how we log details when waiting for connections

Resolves dotnet#570

Testing showed that mlaunch doesn't quit when app is finished though (dotnet#574)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants