Don't log an error when a BackgroundService is canceled due to the host being stopped. #57005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st being stopped. Fix dotnet#56032
eerhardt
requested review from
davidfowl,
Tratcher,
maryamariyan and
IEvangelist
|
Tagging subscribers to this area: @eerhardt, @maryamariyan |
davidfowl
reviewed
Aug 6, 2021
src/libraries/Microsoft.Extensions.Hosting/src/Internal/Host.cs
Outdated
Show resolved
Hide resolved
|
I think you could simplify this by never unsetting the stopping flag. |
I thought about that, but it feels wrong to still have "_stopping = true" once the Host is done stopping. Maybe I could rename it to |
|
Yep lets rename it. Since you can't restart it simplifies the thing. Well the indenting 😄 |
davidfowl
reviewed
Aug 6, 2021
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/Internal/HostTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Aug 9, 2021
src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/Internal/HostTests.cs
Outdated
Show resolved
Hide resolved
- Make it obvious the test is using the default worker template
maryamariyan
approved these changes
Aug 9, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #56032