Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable 2 memory heavy array tests for 2 distros #57108

Merged
merged 2 commits into from
Aug 11, 2021

Conversation

danmoseley
Copy link
Member

Fix #56567

We know System.Runtime OuterLoop tests began failing regularly but sporadically on Ubuntu 18.04 and SLES 15 starting the day after this change added a new such test in April
https://github.com/dotnet/runtime/pull/51548/files?diff=unified&w=1

There is already a test that allocates 1GB, which apparently was passing OK, but perhaps adding a 2nd running immediately afterwards is causing the GC to allocate more pages than it did when there was just one. My assumption is that these two distros are configured to be more aggressive with the OOM killer, or are configured with different memory, and the difference is not interesting. So, disabling the two tests for those distros.

@ghost
Copy link

ghost commented Aug 10, 2021

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Fix #56567

We know System.Runtime OuterLoop tests began failing regularly but sporadically on Ubuntu 18.04 and SLES 15 starting the day after this change added a new such test in April
https://github.com/dotnet/runtime/pull/51548/files?diff=unified&w=1

There is already a test that allocates 1GB, which apparently was passing OK, but perhaps adding a 2nd running immediately afterwards is causing the GC to allocate more pages than it did when there was just one. My assumption is that these two distros are configured to be more aggressive with the OOM killer, or are configured with different memory, and the difference is not interesting. So, disabling the two tests for those distros.

Author: danmoseley
Assignees: -
Labels:

area-System.Runtime

Milestone: -

@danmoseley
Copy link
Member Author

Updated

@stephentoub stephentoub merged commit c59d200 into dotnet:main Aug 11, 2021
@danmoseley danmoseley deleted the array.test2 branch August 11, 2021 00:14
@ghost ghost locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test Group Failure: System.Runtime.Tests outerloop
2 participants