Use XHarnessApkToTest to create helix work items for runtime tests when running on Android

[fanyang-mono]

No description provided.

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[premun]

This is the correct approach and what I hoped the solution might look like. Just beware that one thing will most likely break for Apple - you won't be able to read env variables, such as $HELIX_WORKITEM_UPLOAD_ROOT, anymore thanks to the launchctl workaround. So if the generated code calling XHarness uses these, it should switch over to variables defined by the Helix SDK (https://github.com/dotnet/arcade/tree/main/src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner#variables-defined-for-apple-scenarios)

[SamMonoRT]

@naricc is going to take a look at the suggested changes and take over this PR

[naricc]

@premun Hey, I have been asked to pickup this work, but I didn't really get to speak to Fan before she went on vacation. I've progressed it with the obvious steps so far, but I am not sure where to go.

I see that it is failing with HelixWorkItems is empty, but I assume the change removing the work items was done for a reason. Is this supposed to use another API that doesn't take HelixWorkItems? Is there a document I should be looking at for how CustomCommands is supposed to work?

[premun]

@naricc the docs for the XHarness part of the Helix SDK are here: https://github.com/dotnet/arcade/blob/main/src/Microsoft.DotNet.Helix/Sdk/tools/xharness-runner/Readme.md

The goal is to define these XHarnessApkToTest items which the Helix SDK will turn into HelixWorkItem (and do some magic around those). You will also need the CustomCommands feature but I see Fan has done that already.

If you see XHarnessApkToTest items defined but not HelixWorkItem, then I can think of 2 possible reasons:

1. You are not turning the feature on (see the How to use section) but I am not sure this is the case since we already include and use XHarness (I think)
2. You are not defining these items well or you do but in some target that runs later than the Helix SDK targets run.

I checked the binlog of your build quickly and I can see you are not defining them at all probably:

[ghost]

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

---

null

Author:	fanyang-mono
Assignees:	-
Labels:	area-Infrastructure
Milestone:	-

[fanyang-mono]

Currently, blocked by dotnet/arcade#7808

[fanyang-mono]

Currently, blocked by dotnet/arcade#7808

This issue has been resolved.

[akoeplinger]

Looks good to me, though @premun is the expert here :)