Add Quic back to aspnetcore transport pack #57338
Conversation
Also make sure that the documentation file is placed next to the reference assembly if such is included as part of a ProjectReference. Also move the IsAspNetCore property into packaging.targets as it's not needed by the binplacing system anymore.
|
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsAlso make sure that the documentation file is placed next to the Also move the IsAspNetCore property into packaging.targets as it's not
|
…7158) * automatically update the assembly version * address feedback * move IsAspNetCoreApp to packaging.targets * make assemblyintef pack private, update header and instructions on building the package in servicing * fixes the allconfig leg * update the docs * Update docs/project/library-servicing.md Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com> Co-authored-by: Viktor Hofer <viktor.hofer@microsoft.com>
|
Failure is #57221. |
| @@ -181,6 +181,7 @@ | |||
| Microsoft.Extensions.Primitives; | |||
| System.Diagnostics.EventLog; | |||
| System.IO.Pipelines; | |||
| System.Net.Quic; | |||
There was a problem hiding this comment.
@ViktorHofer I dont this as a part of the aspnetcore ref pack(preview 7) ? whats the reason behind including this ?
There was a problem hiding this comment.
It was part of the transport package so it should continue to be part of it. Check the transport package before the pkgproj to csproj migration: https://dnceng.visualstudio.com/public/_packaging?_a=package&feed=dotnet6-transport%40Local&package=Microsoft.AspNetCore.Internal.Transport&protocolType=NuGet&version=6.0.0-rc.1.21401.1&view=overview.
We carry this along in the transport package and aspnetcore then excludes the assembly.
There was a problem hiding this comment.
But here we are using this list to not update the assembly versions for the things which are part of the ref pack during servicing. As system.Net.Quic is not a part of the ref packs we should be able to update the assembly verison.
We could just manually add a project reference to the transport package to have this assembly.
There was a problem hiding this comment.
System.Net.Quic is already part of the Microsoft.NETCore.App shared framework:
. It doesn't matter if it's added to the package via a direct ProjectReference or via an entry in the AspNetCoreAppLibrary property.There was a problem hiding this comment.
My only concern left here is that having it in the AspNetCoreAppLibrary property implies that its the part of the aspnetcore shared framework which it is not.
There was a problem hiding this comment.
Which definitely is a valid concern. Just don't want to again move things around before branching off.
ghost
locked as resolved and limited conversation to collaborators
System.Net.Quic was accidentally dropped from aspnetcore transport
package with 4684a1d. Reverting that.
Make sure that the documentation file is placed next to the
reference assembly if such is included as part of a ProjectReference.
Don't include pdbs for reference assemblies as those aren't needed
in the transport package.
Move the IsAspNetCore property into packaging.targets as it's not
needed by the binplacing system anymore.