-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Zero
and IsZero
properties to Quaternion
.
#57354
Conversation
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsThis pull request resolves #57253.
|
Hi @Takym! Thanks for the PR. Unfortunately the original issue is not yet marked api-approved, so we can't accept this PR at this time. See https://github.com/dotnet/runtime/blob/main/docs/project/api-review-process.md#pull-requests for more information on the API approval process and the timelines for when PRs are accepted. |
Hello @GrabYourPitchforks! Thank you for replying. Do I need to re-create a PR when the original issue is marked as api-approved, or will you reopen this PR? |
I think you have the power to reopen the PR yourself at the right time. If not, leave a comment here and somebody should be able to reopen it on your behalf. The system won't auto-lock the issue for quite some time. |
I clearly understood. Thanks. |
Would you please reopen this PR because the issue was marked as api-approved? |
@Takym Reopening. Only the Don't forget to update the ref assemblies Edit: Looks like you already beat me to the unit tests! |
I added property definitions to the reference assembly in 7a54468. Also, I have created a "no |
This can be closed now that #58406 has been opened, yes? |
@stephentoub Yes. |
This pull request resolves #57253.