[Group 4] Enable nullable annotations for Microsoft.Extensions.Configuration.EnvironmentVariables
#57433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
community-contribution
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @maryamariyan, @safern Issue DetailsNotes:
|
maxkoshevoi
changed the title
Microsoft.Extensions.Configuration.EnvironmentVariables
# Conflicts: # src/libraries/Microsoft.Extensions.Configuration.Abstractions/ref/Microsoft.Extensions.Configuration.Abstractions.csproj # src/libraries/Microsoft.Extensions.Configuration.Abstractions/src/Microsoft.Extensions.Configuration.Abstractions.csproj # src/libraries/Microsoft.Extensions.Configuration.EnvironmentVariables/ref/Microsoft.Extensions.Configuration.EnvironmentVariables.csproj # src/libraries/Microsoft.Extensions.Configuration.EnvironmentVariables/src/Microsoft.Extensions.Configuration.EnvironmentVariables.csproj # src/libraries/Microsoft.Extensions.Configuration/ref/Microsoft.Extensions.Configuration.csproj # src/libraries/Microsoft.Extensions.Configuration/src/Microsoft.Extensions.Configuration.csproj
…ion-EnvironmentVariables
- Add necessary TFMs - Make configureSource action nullable
eerhardt
approved these changes
Nov 18, 2021
Member
eerhardt
left a comment
eerhardt
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the contribution here, @maxkoshevoi.
I pushed 2 changes:
- Merge with main
- Adding the necessary TFMs + one tweak to the
AddEnvironmentVariables(builder, action)API to make the action nullable.
Will merge when the CI is green.
Member
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
wasm failure is #61749. |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #43605, #54012
Annotated according to:
Microsoft.Extensions.Configuration#57414