Give tvOS a special value for Personal/MyDocuments

[directhex]

Fixes #34007
Fixes #57638

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

[steveisok]

@directhex Looks like the test fails with:

FileCleanupTestBase failed to create /tmp/EnvironmentTests_kvqum5t0.rc2. 
System.UnauthorizedAccessException: Access to the path '/tmp/EnvironmentTests_2duc5dna.12u' is denied.
System.IO.IOException: Operation not permitted\n   --- End of inner exception stack trace ---
System.IO.FileSystem.CreateDirectory(String fullPath)\n   at System.IO.Directory.CreateDirectory(String path)
 at System.IO.FileCleanupTestBase..ctor(String tempDirectory)\nSystem.UnauthorizedAccessException: Access to the path '/tmp/EnvironmentTests_u3jh2qus.e4b' is denied.\n ---> System.IO.IOException: Operation not permitted
  --- End of inner exception stack trace ---\n   at System.IO.FileSystem.CreateDirectory(String fullPath)
at System.IO.Directory.CreateDirectory(String path)\n   at System.IO.FileCleanupTestBase..ctor(String tempDirectory)\nSystem.UnauthorizedAccessException: Access to the path '/tmp/EnvironmentTests_kvqum5t0.rc2' is denied.
 ---> System.IO.IOException: Operation not permitted\n   --- End of inner exception stack trace ---
 at System.IO.FileSystem.CreateDirectory(String fullPath)\n   at System.IO.Directory.CreateDirectory(String path)
at System.IO.FileCleanupTestBase..ctor(String tempDirectory)

Expected: True
Actual:   False

[directhex]

@directhex Looks like the test fails with:

FileCleanupTestBase failed to create /tmp/EnvironmentTests_kvqum5t0.rc2. 
System.UnauthorizedAccessException: Access to the path '/tmp/EnvironmentTests_2duc5dna.12u' is denied.
System.IO.IOException: Operation not permitted\n   --- End of inner exception stack trace ---
System.IO.FileSystem.CreateDirectory(String fullPath)\n   at System.IO.Directory.CreateDirectory(String path)
 at System.IO.FileCleanupTestBase..ctor(String tempDirectory)\nSystem.UnauthorizedAccessException: Access to the path '/tmp/EnvironmentTests_u3jh2qus.e4b' is denied.\n ---> System.IO.IOException: Operation not permitted
  --- End of inner exception stack trace ---\n   at System.IO.FileSystem.CreateDirectory(String fullPath)
at System.IO.Directory.CreateDirectory(String path)\n   at System.IO.FileCleanupTestBase..ctor(String tempDirectory)\nSystem.UnauthorizedAccessException: Access to the path '/tmp/EnvironmentTests_kvqum5t0.rc2' is denied.
 ---> System.IO.IOException: Operation not permitted\n   --- End of inner exception stack trace ---
 at System.IO.FileSystem.CreateDirectory(String fullPath)\n   at System.IO.Directory.CreateDirectory(String path)
at System.IO.FileCleanupTestBase..ctor(String tempDirectory)

Expected: True
Actual:   False

Not guilty. I reverted all my changes to System.Environment, and the device build still fails.

/tmp is readonly on device. Path.GetTempPath is what fails, and it's not due to my changes.

[directhex]

Passing test run at https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-57508-merge-1e248fd4fd8041158e/System.Runtime.Extensions.Tests/1/testResults.xml?sv=2019-07-07&se=2021-09-07T13%3A54%3A41Z&sr=c&sp=rl&sig=X2d4WGNqdxm%2F4lRmavZl2PXh05ungy7cYL%2FDYbQ3wto%3D

[directhex]

i can't get a dang thing to run on my iPhone 😠

[directhex]

/backport to release/6.0-rc1

[github-actions]

Started backporting to release/6.0-rc1: https://github.com/dotnet/runtime/actions/runs/1163777452

[github-actions]

@directhex backporting to release/6.0-rc1 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Use a different Personal folder on tvOS, and a test that it works
Applying: Run this PR on device, the error does not happen on sim
Applying: CI fixes
Applying: Nullable
Applying: Test on devices
Applying: Just run one test to save disk space
Applying: Tweak to run only 1 test and make sure DevTeamProvisioning is right
Applying: Horrible hack to check something in CI
Applying: Revert all changes. Run as-is in CI to see if it's my changes to blame
Applying: nonsense
Applying: Set temp path to a valid location
Applying: Fix AppDomainTests.ExecuteAssembly to copy files to a valid place
Applying: Don't expect HOME to work on tvOS
Applying: We cannot get exit code from tvOS device, so runonly tests don't work
Applying: Revert infra changes made to enable CI of this PR, which passes now on device
error: sha1 information is lacking or useless (eng/testing/tests.mobile.targets).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0015 Revert infra changes made to enable CI of this PR, which passes now on device
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[marek-safar]

/backport to release/6.0

[github-actions]

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1175024534

[github-actions]

@marek-safar backporting to release/6.0 failed, the patch most likely resulted in conflicts:

$ git am --3way --ignore-whitespace --keep-non-patch changes.patch

Applying: Use a different Personal folder on tvOS, and a test that it works
Applying: Run this PR on device, the error does not happen on sim
Applying: CI fixes
Applying: Nullable
Applying: Test on devices
Applying: Just run one test to save disk space
Applying: Tweak to run only 1 test and make sure DevTeamProvisioning is right
Applying: Horrible hack to check something in CI
Applying: Revert all changes. Run as-is in CI to see if it's my changes to blame
Applying: nonsense
Applying: Set temp path to a valid location
Applying: Fix AppDomainTests.ExecuteAssembly to copy files to a valid place
Applying: Don't expect HOME to work on tvOS
Applying: We cannot get exit code from tvOS device, so runonly tests don't work
Applying: Revert infra changes made to enable CI of this PR, which passes now on device
error: sha1 information is lacking or useless (eng/testing/tests.mobile.targets).
error: could not build fake ancestor
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0015 Revert infra changes made to enable CI of this PR, which passes now on device
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128

Please backport manually!

[directhex]

@marek something about one of the commits in this PR angers the backport bot, I've issued a backport from the release/6.0-rc1 backport, which should be fine: #58286