Add --make-repro-path option to crossgen2 #57543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This is used to create repro packages for customer discovered issues with CrossGen2 - Customers will use this by setting the PublishCrossGen2ExtraArgs property to something like `--make-repro-path:c:\repro\crossgen2repro` - Then the build will run, and produce zip files in the specified directory, one for each crossgen2 run that occurs during that build. - Hopefully, then it is straightforward to package the failure up and send it in. In addition, this tech can be used to transfer a full set of repro details from a Unix to Windows machine for easier debugging.
davidwrighton
requested review from
trylek and
AntonLapounov
and removed request for
trylek
|
@tommcdon Tom, while I was debugging one of our first in the wild crossgen2 issues, it was suggested by @AndyAyersMS to build the ability to package up the inputs to crossgen2 as an zip package. I know you have some experience with these things. What do you think of this approach? |
|
I assume #57535 was done using this command? Cool! |
trylek
approved these changes
Aug 17, 2021
| } | ||
| else | ||
| { | ||
| rspFile.Add($"{ConvertFromInputPathToReproPackagePath((string)parameter.Value.ToString())}"); |
There was a problem hiding this comment.
Nit: I guess casting to string is a no-op here.
| string zipFileName = ((uint)hashCodeOfArgs.ToHashCode()).ToString(); | ||
|
|
||
| if (OutputFilePath != null) | ||
| zipFileName = zipFileName + "_" + Path.GetFileName(OutputFilePath); |
There was a problem hiding this comment.
Nit: If there are multiple repro files in the same directory, it might be easier to search through them if we put OutputFilePath at the beginning.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PublishCrossGen2ExtraArgsproperty to something like--make-repro-path:c:\repro\crossgen2reproIn addition, this tech can be used to transfer a full set of repro details from a Unix to Windows machine for easier debugging.