Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FOREACH_REGISTER_FILE macro #57613

Merged
merged 1 commit into from
Aug 20, 2021
Merged

Remove FOREACH_REGISTER_FILE macro #57613

merged 1 commit into from
Aug 20, 2021

Conversation

echesakov
Copy link
Contributor

@echesakov echesakov commented Aug 17, 2021 •
edited
Loading

Replace FOREACH_REGISTER_FILE macro with lambda.

@echesakov echesakov added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Aug 17, 2021
@echesakov echesakov added this to the 7.0.0 milestone Aug 17, 2021
@echesakov echesakov self-assigned this Aug 17, 2021
@ghost
Copy link

ghost commented Aug 17, 2021

Tagging subscribers to this area: @JulieLeeMSFT
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: echesakovMSFT
Assignees: echesakovMSFT
Labels:

area-CodeGen-coreclr
Milestone: 7.0.0

@runfoapp runfoapp bot mentioned this pull request Aug 18, 2021
Closed
@echesakov echesakov closed this Aug 19, 2021
@echesakov echesakov reopened this Aug 19, 2021
@runfoapp runfoapp bot mentioned this pull request Aug 19, 2021
Closed
@echesakov echesakov marked this pull request as ready for review August 20, 2021 01:16
@echesakov
Copy link
Contributor Author

@dotnet/jit-contrib PTAL

kunalspathak
kunalspathak approved these changes Aug 20, 2021
View reviewed changes
Copy link
Member

@kunalspathak kunalspathak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@echesakov echesakov merged commit 183c7d0 into dotnet:main Aug 20, 2021
@echesakov echesakov deleted the Remove-FOREACH_REGISTER_FILE-Macro branch August 20, 2021 14:33
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kunalspathak kunalspathak kunalspathak approved these changes

Assignees

@echesakov echesakov

Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
.NET Core CodeGen
Archived in project
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@echesakov @kunalspathak