Unused functions in InvokeUtil #57615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
reviewed
Aug 17, 2021
| @@ -169,7 +169,6 @@ DEFINE_CLASS(ATTRIBUTE, System, Attribute) | |||
|
|
|||
|
|
|||
| DEFINE_CLASS(BINDER, Reflection, Binder) | |||
There was a problem hiding this comment.
Suggested change
| DEFINE_CLASS(BINDER, Reflection, Binder) |
Can this be deleted too?
There was a problem hiding this comment.
The Binder class is still part of some signatures for other functions that are used - for example:
runtime/src/coreclr/vm/metasig.h
Line 470 in a53ec50
runtime/src/coreclr/vm/corelib.h
Line 529 in a53ec50
jkotas
reviewed
Aug 17, 2021
Co-authored-by: Jan Kotas <jkotas@microsoft.com>
jkotas
approved these changes
Aug 18, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.